Major rewrite landcover labelling #941
Conversation
|
Please don't merge this yet, I would like to receive some feedback first. Here follow some rendering examples. All landuse types before and after: Z14 before and after (note that the names of the larger landuses Cimetiere de Merl, Campus Geeseknappchen, and Parc Niedergrunewald now appear, and note that the forest names Lei and Enneschte Besch are now rendered larger): Z15 before and after (note that the name of Cimetiere de Merl is now rendered larger, but the names of the small sport clubs, schools, and allotments remain hidden): Z16 before and after (the cemetery name is now rendered even bigger, and the names of the sports clubs show up): |
|
Some notes:
|
|
University oblique is ok for me as they can be quite large as in Aachen. |
|
I think this is a nice enhancement, and will generally work out quite well. Just a couple of remarks:
|
Thanks, fixed. Also thanks for your other comments. |
|
You could probably include the glaciers and get rid of the separate layer currently used for that |
|
Just one other remark: is "barracks" really a landuse in OSM? Barracks are military buildings part of a military base (which is probably a landuse by itself, e.g. there is naval_base and airfield). The wiki page for the key military also describes barracks as "Buildings where soldiers live and work": http://wiki.openstreetmap.org/wiki/Key:military It may also be more useful to label each barrack building itself with the name and ref key... |
|
Very nice! What a neat trick to show larger areas with more prominent labeling, it makes a lot of sense .
Actually, sometimes it would be useful. Zooming in on e.g. a lake, desert or large forest, I would like to see the name of that big area in my viewport, even if it's not the middle of the area that I'm looking at. But that's another issue. |
Yes, but probably can't get to it for a couple days at least. |
|
It would resolve also #455 |
matthijsmelissen
force-pushed
the
landcover-labels
branch
from
a471e72
to
15e5c0e
Compare
|
Rebased. Please merge #968 first. |
|
@pnorman Any chance of getting the demo up this week? |
|
Tiles at http://tile.paulnorman.ca/landcover-labels/z/x/y.png |
Thanks. I quickly set up a slippy map: http://matthijsmelissen.nl/temp/osm/landcover-labels/ However, it seems there is something wrong with your database, most stuff is missing. Or does it only work in certain regions? Edit: I see now that it does work in the Northeastern US. That should be a good start for testing. |
|
I also set up http://tile.paulnorman.ca/demo/landcover-labels.html, which has a slider. Areas loaded are defined in a furry-sansa config as Note, city extracts failed to load as Mapzen changed the URLs. |
Great, then I'll drop my slippy map. |
|
I'm still seeing old styling sporatically. Have a look at the Cascade Recreation Area, Skagit Valley Provincial Park, and E.C. Manning Provincial Park. z8 new z9 new z10 new Metatile issues seem worse. That's probably just my server. Tetrahedron Provincial Park label disappears from z10 to z11 The peaks are probably displacing it, and it's not a regression, so I'll open a new issue. Mt. Baker - Snoqualmie National Forest isn't showing up. Not sure why, doesn't seem to be conflicting, on a MT boundary, or too small to label. The halo seems to be enough to avoid the green on green problem, but maybe it should be slightly more? On busy parks it tends to get lost slightly. Speaking as someone who lives in an area with some massive parks and forests, I like the effect it has on low zooms. |
No need to if you don't want to - load would be the same on my server. Also, I'm not worried about server load. Initial low-zoom rendering might be slow, but the server caches everything and because it doesn't consume updates, never invalidates its cache. |
This commit changes the rendering of landcover labels. For the purpose of this commit, with 'landcover label' we mean text connected to a background colour or pattern rendering, and not connected to an icon. * All rendered landcover tags now have their name rendered (resolves gravitystorm#537). We add labels to the following tags: * natural=beach,scrub,grassland,heath,sand,desert (partially resolves gravitystorm#788) * highway=services,rest_area (resolves gravitystorm#575) * aeroway=apron * power=station,generator,substation,sub_station * tourism=zoo * military=barracks * The minimum zoom level of labels is now defined based on the number of pixels rendered (resolves partially gravitystorm#703, resolves gravitystorm#861, resolves gravitystorm#913). Labels are rendered from 3000 pixels (but never earlier than the corresponding landuse is rendered). * Font size now also depends on way_pixels. In other words, larger objects get a larger label, in three steps (resolves gravitystorm#308). * Landuse labels are now rendered oblique, to easier visually tell them apart from village and POI labels. * All labels are rendered in a colour similar to the landuse they belong to (using landuse color variables, resolves gravitystorm#56). Also some existing colours are changed, in order to make them clearly colourful but still readable. * The text-halo-radius and text-wrap-width properties are made consistent across landuse types. * Font-size, wrap-width an face-name are now defined by easy to change variables.
matthijsmelissen
force-pushed
the
landcover-labels
branch
from
7dc09c5
to
c0e1a2e
Compare
|
Very very cool :) If the white halo looks to obtrusive when its fatter, we could use the colour of the landuse for it. It should look fine, as long as the text is different enough from the landuse. |
@imagico I think this is (at least partially) caused by the national park overlay, which makes everything look greenish (nice example of the reason why we don't like transparency). Does it look better on higher zoom levels, where the national park overlay is no longer rendered, for example here? |
|
@math1985 Old colour of glacier label is still better on linke zoom level and lower ones. |
|
This is too good to wait! There's a few minor things that we can follow up on separately, and I've been playing around with making the halo colours match the polyon colours - it looks good in many cases, but some times it's terrible! Anyway, lets see this in production and go from there. Great work again by @math1985 |
|
wow, excellent work! |
|
It's starting to show up on the map -- nice! Thank you @ALL, not just for this, but also for all the other improvements! Also big thank yous for things that don't show up on the map, but make it easier to make it better (JSON, Yaml, ??) |
|
I would like to thank everyone for their comments. Sorry for not responding to them earlier.
Not sure what the problem was, but on the production server, it works fine.
See #1046.
Yes, with text-placements, but not in the current Mapnik version, or by triplicating the layers, but I think that would have a huge performance and code-maintenance penalty. Do we want this?
See #1047.
See #1048.
In my opinion, the label size is fine there.
See #1026.
Yes, this is one of the next steps.
See #1016.
See #1031.
Yes, glacier labels are no longer prioritized over symbols (just like other labels). #1046 should solve this at least partially.
It seems the harbour here is also larger than the town... Do you propose rendering either towns larger or landuse labels smaller?
Correct. In general, I think missing street names are a larger problem when navigating.
True. Not sure what to do about this.
At least the Dutch community seems to be of the opinion that this is a tagging problem.
See #1048. If there is anything people feel deserves more attention, feel free to open a new issue. And sorry for my telegram-style response, but there was just a lot to respond to. |
This commit changes the rendering of landcover labels.
For the purpose of this commit, with 'landcover label' we mean text connected to
a background colour or pattern rendering, and not connected to an icon.
add labels to the following tags:
rendered (resolves partially The use of way_area #703, resolves render the name of big military areas earlier #861, resolves landuse labels should appear at z14 #913, resolves Display national parks names also on 12 and 13 #566).
Labels are rendered from 3000 pixels (but never earlier than the corresponding
landuse is rendered).
a larger label, in three steps (resolves Tourism=theme_park label is unreadable and lacks priority. #308).
from village and POI labels.
(using landuse color variables, resolves associate label styles with the features they label #56). Also some existing colours
are changed, in order to make them clearly colourful but still readable.
landuse types.
variables.