Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

➖ Remove unused junit dependency #161

Merged
merged 7 commits into from
Apr 14, 2023
Merged

➖ Remove unused junit dependency #161

merged 7 commits into from
Apr 14, 2023

Conversation

natixis-caen
Copy link
Contributor

@natixis-caen natixis-caen commented Apr 6, 2023 •
edited
Loading

@MP-Aubay MP-Aubay added dependencies Pull requests that update a dependency file 🏗️ refactoring refactoring for best practices labels Apr 7, 2023
dedece35
dedece35 requested changes Apr 9, 2023
View reviewed changes
Copy link
Member

@dedece35 dedece35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @natixis-caen,

ok for me. test ok in my local machine.

but can you add a CHANGELOG .md entry please ? (with a link to this PR)

Thank you sir !

@dedece35 dedece35 added the 👀 👀 review done 👀 👀 review done - waiting for changes label Apr 9, 2023
@natixis-caen
Copy link
Contributor Author

Hi @dedece35,
It should be fine now, I updated the changelog.

@dedece35
Copy link
Member

Hi @natixis-caen,
could you now correct new added code smells : check SonarCloud report above.
thank you.

@dedece35
Copy link
Member

HI @natixis-caen,
thanks for upgrade but tests KO :(
please check them

@sonarcloud
Copy link

sonarcloud bot commented Apr 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@natixis-caen
Copy link
Contributor Author

Tests are all good now.

@dedece35 dedece35 merged commit 56a4498 into green-code-initiative:main Apr 14, 2023
@dedece35 dedece35 removed the 👀 👀 review done 👀 👀 review done - waiting for changes label May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utarwyn utarwyn utarwyn approved these changes

@dedece35 dedece35 dedece35 approved these changes

Assignees

@natixis-caen natixis-caen

Labels
🏗️ refactoring refactoring for best practices dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@natixis-caen @dedece35 @utarwyn @MP-Aubay