Fix config test for tomlkit 0.7.2 #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The config_dict is some tomlkit extended dict class. With some tomlkit 0.7.1 or 0.7.2 a single test broke. At some place some of this dict classes might return a proxy to a class and in the next iteration this proxy doesn't work anymore because something is freed internally. Therefore always copy the object to not free the data.
Codecov Report
@@ Coverage Diff @@
## master #132 +/- ##
=======================================
Coverage 49.32% 49.32%
=======================================
Files 13 13
Lines 596 596
=======================================
Hits 294 294
Misses 302 302
Continue to review full report at Codecov.
|
y0urself
approved these changes
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fix a nasty issue with testing getting a config value with up to date tomlkit 0.7.2
Why:
The config_dict is some tomlkit extended dict class. With some tomlkit
0.7.1 or 0.7.2 a single test broke. At some place some of this dict
classes might return a proxy to a class and in the next iteration this
proxy doesn't work anymore because something is freed internally.
Therefore always copy the object to not free the data.
How:
Checklist: