Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix config test for tomlkit 0.7.2 #132

Merged
merged 3 commits into from
May 25, 2021
Merged

Fix config test for tomlkit 0.7.2 #132

merged 3 commits into from
May 25, 2021

Commits on May 25, 2021

  1. Update to tomlkit 0.7.2

    @bjoernricks
    bjoernricks committed May 25, 2021
    Configuration menu
    Copy the full SHA
    7f9d43e View commit details
    Browse the repository at this point in the history

  2. Fix iterating over the config 

    The config_dict is some tomlkit extended dict class. With some tomlkit
0.7.1 or 0.7.2 a single test broke. At some place some of this dict
classes might return a proxy to a class and in the next iteration this
proxy doesn't work anymore because something is freed internally.
Therefore always copy the object to not free the data.
    @bjoernricks
    bjoernricks committed May 25, 2021
    Configuration menu
    Copy the full SHA
    7c0d7e8 View commit details
    Browse the repository at this point in the history

  3. Add changelog entry

    @bjoernricks
    bjoernricks committed May 25, 2021
    Configuration menu
    Copy the full SHA
    e429534 View commit details
    Browse the repository at this point in the history