Errorboundary improvements #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## gsa-8.0 #1403 +/- ##
===========================================
+ Coverage 36.47% 36.52% +0.04%
===========================================
Files 960 960
Lines 21664 21673 +9
Branches 6025 6007 -18
===========================================
+ Hits 7901 7915 +14
+ Misses 12433 12428 -5
Partials 1330 1330
Continue to review full report at Codecov.
|
Only passing the element where the error did occur doesn't work for translations. Therefore expect a full message string now.
Use same error boundary for all rendered pages after login.
Rendering the ErrorBoundary component for catching errors at this components got moved to the parent Page component. Therefore these ErrorBoundary components can be removed safely.
Always provide a message string for all ErrorBoundary components.
The directory contains error related components now not only for the error boundary.
Also add an extended margin between the icon and texts.
Allow to display component and error stack traces if the user clicks on show error details.
Don't wrap stacktrace and show scrollbar at x axis if text is to wide.
It's completely unexpected and unpredictable that the datepicker css class names are changing for unrelated changes...
sarahd93
requested changes
May 15, 2019
Update spelling of error messages. Co-Authored-By: sarahd93 <sarah.diedrich93@gmail.com>
sarahd93
approved these changes
May 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: