Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errorboundary improvements #1403

Merged
merged 16 commits into from
May 15, 2019
Merged

Errorboundary improvements #1403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
b3111a4
Expect a full message for ErrorBoundary component
bjoernricks May 14, 2019
d2aae98
Add an ErrorBoundary to the Page component
bjoernricks May 14, 2019
7680768
Drop all unnecessary ErrorBoundary components
bjoernricks May 14, 2019
c53aaeb
Add messages for all ErrorBoundary components
bjoernricks May 14, 2019
3f8e3b1
Rename errorboundary directory to error
bjoernricks May 14, 2019
bab4683
Update German translations after message strings got changed
bjoernricks May 14, 2019
2c9cec7
Extend ErrorMessage for easier styling of content
bjoernricks May 14, 2019
09d4f1b
Extend ErrorBoundary to allow to display error details
bjoernricks May 14, 2019
f69b1e0
Improve styling of error details
bjoernricks May 14, 2019
98a0667
Fix German translation for errors at dashboards
bjoernricks May 14, 2019
ca89cb0
Add German translation for toggling error details
bjoernricks May 14, 2019
1634248
Update changelog for error details
bjoernricks May 14, 2019
17f2d70
Update snapshot of Datepicker component
bjoernricks May 14, 2019
e3a71d7
Set data-testids for easier testing
bjoernricks May 14, 2019
5af7dfc
Add tests for error components
bjoernricks May 14, 2019
70624f7
Apply suggestions from code review
bjoernricks May 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
## [8.0.1] - (unreleased)

### Added
- Allow to show error details [#1403](https://github.com/greenbone/gsa/pull/1403)
- Add test for solution type group [#1402](https://github.com/greenbone/gsa/pull/1402)
- Add tests for loginpage and structure components [#1390](https://github.com/greenbone/gsa/pull/1390)
- Add getAllEntities() and loadAllEntities() actions and reducers to entities store [#1345](https://github.com/greenbone/gsa/pull/1345)
Expand All @@ -16,7 +17,10 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).
- Add new DefaultFilterSettings to UserSettings [#1326](https://github.com/greenbone/gsa/pull/1326)
- Add warning for IE11 [#1322](https://github.com/greenbone/gsa/pull/1322)
- Add tests for label and img [#1313](https://github.com/greenbone/gsa/pull/1313)
- German translation [#1311](https://github.com/greenbone/gsa/pull/1311)[#1323](https://github.com/greenbone/gsa/pull/1323)
- German translation
[#1311](https://github.com/greenbone/gsa/pull/1311),
[#1323](https://github.com/greenbone/gsa/pull/1323),
[#1403](https://github.com/greenbone/gsa/pull/1403)
- Add tests for comment and badge [#1309](https://github.com/greenbone/gsa/pull/1309)
- Add error dialog to fix missing error messages in trashcan [#1286](https://github.com/greenbone/gsa/pull/1286)
- Display current result, comparable result and diff between results for delta
Expand Down
5 changes: 3 additions & 2 deletions gsa/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,8 +245,9 @@ set (GSA_JS_SRC_FILES
${GSA_SRC_DIR}/src/web/components/dialog/scrollablecontent.js
${GSA_SRC_DIR}/src/web/components/dialog/title.js
${GSA_SRC_DIR}/src/web/components/dialog/twobuttonfooter.js
${GSA_SRC_DIR}/src/web/components/errorboundary/errorboundary.js
${GSA_SRC_DIR}/src/web/components/errorboundary/errorcontainer.js
${GSA_SRC_DIR}/src/web/components/error/errorboundary.js
${GSA_SRC_DIR}/src/web/components/error/errorcontainer.js
${GSA_SRC_DIR}/src/web/components/error/errormessage.js
${GSA_SRC_DIR}/src/web/components/folding/folding.js
${GSA_SRC_DIR}/src/web/components/footnote/footnote.js
${GSA_SRC_DIR}/src/web/components/form/button.js
Expand Down
Loading