Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update invalid url handling #1603

Merged
merged 7 commits into from
Sep 3, 2019
Merged

Update invalid url handling #1603

merged 7 commits into from
Sep 3, 2019

Conversation

bjoernricks
Copy link
Contributor

@bjoernricks bjoernricks commented Sep 3, 2019 •
edited
Loading

Fix #1601 and use js to handle nearly all urls now.

@bjoernricks
Always escape url when creating a 404 page in gsad
2ff91fd 
Fixes #1601
@bjoernricks
Allow js code handle not found pages
ab4648c 
All unknown urls will now return the index.html page and the js code
will handle them accordingly. Thus the whole url handling besides
/gmp, /system_report and static files is done in js now.
@bjoernricks bjoernricks changed the base branch from master to gsa-8.0 September 3, 2019 08:05
@bjoernricks bjoernricks marked this pull request as ready for review September 3, 2019 08:09
@bjoernricks bjoernricks requested a review from a team September 3, 2019 08:09
@bjoernricks
Avoid including URL in 404 response
de4e3d6 
Be even more restrictive by not including user URL in 404 response.
@bjoernricks
Return bad request response if url is invalid
a3c8a46 
Don't send 404 page if the url start with two slashes. Instead it is an
invalid request.
@bjoernricks
Drop unused handler_send_not_found function
19b541e 
The function is unsed now.
@bjoernricks
Drop url param from create_not_found_response function
ce629e2 
The url param isn't used anymore.
swaterkamp
swaterkamp approved these changes Sep 3, 2019
View reviewed changes
Copy link
Member

@swaterkamp swaterkamp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my(!) point of view, this looks ok.

@bjoernricks bjoernricks merged commit fcd6904 into greenbone:gsa-8.0 Sep 3, 2019
@bjoernricks bjoernricks deleted the update-invalid-url-handling branch September 3, 2019 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swaterkamp swaterkamp swaterkamp approved these changes

@timopollmeier timopollmeier timopollmeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bjoernricks @swaterkamp @timopollmeier