Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update invalid url handling #1603

Merged
merged 7 commits into from
Sep 3, 2019
Merged

Update invalid url handling #1603

merged 7 commits into from
Sep 3, 2019

Commits on Sep 3, 2019

  1. Always escape url when creating a 404 page in gsad 

    Fixes #1601
    @bjoernricks
    bjoernricks committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    2ff91fd View commit details
    Browse the repository at this point in the history

  2. Allow js code handle not found pages 

    All unknown urls will now return the index.html page and the js code
will handle them accordingly. Thus the whole url handling besides
/gmp, /system_report and static files is done in js now.
    @bjoernricks
    bjoernricks committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    ab4648c View commit details
    Browse the repository at this point in the history

  3. Add changelog entry for 404 url handling fix in gsad

    @bjoernricks
    bjoernricks committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    57bf2c7 View commit details
    Browse the repository at this point in the history

  4. Avoid including URL in 404 response 

    Be even more restrictive by not including user URL in 404 response.
    @bjoernricks
    bjoernricks committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    de4e3d6 View commit details
    Browse the repository at this point in the history

  5. Return bad request response if url is invalid 

    Don't send 404 page if the url start with two slashes. Instead it is an
invalid request.
    @bjoernricks
    bjoernricks committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    a3c8a46 View commit details
    Browse the repository at this point in the history

  6. Drop unused handler_send_not_found function 

    The function is unsed now.
    @bjoernricks
    bjoernricks committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    19b541e View commit details
    Browse the repository at this point in the history

  7. Drop url param from create_not_found_response function 

    The url param isn't used anymore.
    @bjoernricks
    bjoernricks committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    ce629e2 View commit details
    Browse the repository at this point in the history