Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support comments in templates #661

Merged
merged 1 commit into from
Jan 9, 2022
Merged

feat: support comments in templates #661

merged 1 commit into from
Jan 9, 2022

Conversation

tu4mo
Copy link
Contributor

@tu4mo tu4mo commented Jan 2, 2022

Summary

Fixes #660.

Test plan

Snapshot test is provided to make sure comments are preserved.

@vercel
Copy link

vercel bot commented Jan 2, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/gregberge/svgr/3FuKZDRFdyvn4vtp62nPUWUQyJxh
✅ Preview: https://svgr-git-fork-tu4mo-main-gregberge.vercel.app

@codecov
Copy link

codecov bot commented Jan 2, 2022

Codecov Report

Merging #661 (a3934a2) into main (17507b4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #661   +/-   ##
=======================================
  Coverage   92.43%   92.43%           
=======================================
  Files          32       32           
  Lines         727      727           
  Branches      239      239           
=======================================
  Hits          672      672           
  Misses         53       53           
  Partials        2        2           
Impacted Files Coverage Δ
.../babel-plugin-transform-svg-component/src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17507b4...a3934a2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

preserveComments with templates
2 participants