Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

\gabcsnippet doesn't obey \greseteolcustos #703

Closed
olivierberten opened this issue Dec 10, 2015 · 4 comments
Closed

\gabcsnippet doesn't obey \greseteolcustos #703

olivierberten opened this issue Dec 10, 2015 · 4 comments
Assignees
Milestone

Comments

@olivierberten
Copy link

If you have a multiline snippet, it will add a custos at the end of the line, even with \greseteolcustos{manual}

@eroux eroux added this to the 4.0 milestone Dec 10, 2015
@henryso
Copy link
Contributor

henryso commented Dec 10, 2015

I cannot reproduce this. Please provide an MWE.

@olivierberten
Copy link
Author

Just figured out the bug appears from the second snippet on.

@henryso
Copy link
Contributor

henryso commented Dec 10, 2015

The value of \greseteolcustos is reset after each score inclusion. It appears to be doing this purposely. Perhaps @rpspringuel can speak to the intent here.

@rpspringuel
Copy link
Contributor

That behavior was pre-existing to my renaming of the commands, but IIRC, \greseteolcustos{manual} is used to suppress the automatic custos at the end of the score (where it is meaningless as there is no next note). Given the assumption that automatic custos are being shown (the default condition) we have to "revert" to \greseteolcustos{auto} so that subsequent scores will have the automatic custos appear.

What we should probably do is separate the persistent flag (the preference) from the immediate flag (should a auto-custos be printed on this line) so that the end of score stuff can change the immediate flag without affecting the persistent one.

This implementation should be very similar to the direction that @henryso took for the hyphen after a 1-letter first syllable.

@henryso henryso self-assigned this Dec 11, 2015
henryso added a commit to henryso/gregorio that referenced this issue Dec 11, 2015
henryso added a commit to henryso/gregorio-test that referenced this issue Dec 11, 2015
rpspringuel added a commit to gregorio-project/gregorio-test that referenced this issue Dec 11, 2015
@henryso henryso closed this as completed Dec 11, 2015
rpspringuel added a commit to rpspringuel/gregorio that referenced this issue Dec 12, 2015
* develop:
  Typo
  Converted the final hyphen in a syllable to \GreForceHyphen Part of the implementation of gregorio-project#705.
  Debug messages and missing `\global`
  Add issue reference to CHANGELOG
  Decouple `\gresethyphen` from `maximumspacewithoutdash`
  Reset custos-blocking at the beginning of each score inclusion. Fixes gregorio-project#703.
  Fixing overzelous find and replace
  Progress 4.0 deprecated functions to obsolete
  Remove obsolete code
rpspringuel added a commit to rpspringuel/gregorio-test that referenced this issue Dec 12, 2015
…bolnoclef

* commit 'ea4a15517e9fe32a61e6602149261ce192cb4cb9':
  Updated test to remove deprecated usage.
  Accepting updated tests
  Add a test to show that hyphenation behavior restores correctly
  Added a test for the fix for gregorio-project/gregorio#703.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants