-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple \gresethyphen{force}
from maximumspacewithoutdash
#705
Comments
Okay, a potentially related issue that I came across while working on this one: Right now the sequence Also, since this new issue will require some modification of the command-line tool code, I'm going to need some help getting it done. |
I can help with this. Would it be OK to change all hyphens to |
If you could, work against hyphen. I just pushed a copy of it from my repository to the main one. I would only convert a hyphen to |
Part of the implementation of gregorio-project#705.
I pushed my changes into the hyphen branch. This breaks the SalveReginaOP test in a good way, but I'll let you confirm and accept that change. |
Fixed #709 |
* develop: Typo Converted the final hyphen in a syllable to \GreForceHyphen Part of the implementation of gregorio-project#705. Debug messages and missing `\global` Add issue reference to CHANGELOG Decouple `\gresethyphen` from `maximumspacewithoutdash` Reset custos-blocking at the beginning of each score inclusion. Fixes gregorio-project#703. Fixing overzelous find and replace Progress 4.0 deprecated functions to obsolete Remove obsolete code
As is, the following will lead to different hyphenation patterns for the first and last occurrences of the score test (which can be most any score with polysyllabic words):
This is because
\gresethyphen{force}
currently changesmaximumspacewithoutdash
to a very large negative number and\gresethyphen{manual}
changes it back to the value found ingsp-default.tex
. However, in the above code block,maximumspacewithoutdash
does not have that default value in the first score because the change in staff size has scaled it up.The fix is to create a flag for
\gresethyphen
to manipulate rather thenmaximumspacewithoutdash
.I'm already working on this, I'm simply creating this issue so that I can reference it in CHANGELOG.md (instead of trying to explain everything there).
The text was updated successfully, but these errors were encountered: