-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completing glyph handling #898
Comments
Thanks! this leaves the following remarks:
|
|
Forget about the bug, I was trying |
Do you have an example of where the inverted |
not at all, all I know is that Solesmes asked me to revert |
Should we follow that sort of thing by default? It certainly is more consistent. |
Thinking about this a little bit, if we are going to change the gabc syntax to handle this, it would be better to do it in 4.1 since the oriscus logic has already changed in this version. |
Applying the rule by default would be best indeed, in 4.1 would be perfect! |
Ok, the hard question. When using the new oriscus orientation rules, |
By the way, I will try to get this done in 4.1, but I cannot promise it will be ready for rc1. |
There are a number of missing glyphs to make this work and it has a strong potential to destabilize the code, so I'm inclined to leave it for 5.0. Part of the problem is that in some shapes, the oriscus direction is implied (so flexus oriscus is an oriscus descendens and pes quassus is an oriscus ascendens). This becomes very confusing when working out the cases. I recommend changing the names of the glyphs in order to make the oriscus direction explicit (i.e., flexus ascendens oriscus and flexus descendens oriscus). This, too, is a very risky step to take before we stabilize for TeX Live. However, if you are OK with using What do you think? |
I agree with everything, let's make the pure |
Part of the implementation for gregorio-project#898 and gregorio-project#972.
Part of the implementation for gregorio-project#898 and gregorio-project#972.
Added change log and upgrade entries to describe the orientation change. Part of the implementation for gregorio-project#898 and gregorio-project#972.
Looking at Nocturnale Romanum:
there are a few glyphs that Gregorio doesn't handle and that seem to be used in Antiphonale Monasticum project. The main one is "virga strata", but it would be good to handle (in the form where the two pitches are not the same, but keeping both notes in the same element when they have the same pitch), and "pes stratus" too. This also raises the question of how to apply the changes made in #744 for combined glyphs. For instance, the pes stratus would have different forms according to the following note, how should the glyphs be named?
This could also be the occasion to apply #744 completely and revert the direction of the oriscus for the
FlexusOriscusScapus
glyph, as these are just plainly wrong in the Nocturnale Romanum, and we copied them. So should we add some.nr
variants for the current ones, and fix the normal form?Note also that NR has a "salicus quassus" figure which looks just plainly wrong, I don't think it should be added to Gregorio...
The text was updated successfully, but these errors were encountered: