Preserve stack traces in Python 2.7 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 similar comments
|
#8 has been squashed and merged, you can rebase now. |
2 similar comments
|
OK, rebased. Took a few passes to get all the tests happy. |
|
Thanks for the quick response! |
PetrDlouhy
pushed a commit
to PetrDlouhy/django-admin-smoke-tests
that referenced
this pull request
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is written against PetrDlouhy's open pull request #8, so I'll have to rebase once that goes in -- sending pull req now to avoid losing track of it.)
The actual change here is tests.py line 29-38, which adds special handling for re-raising errors under Python 2.7.
six.raise_fromjust throws away the original exception under Python 2. So you end up with an exception like:ModelAdminCheckException: Above exception occured while running test 'test_queryset', but there is no exception above, making the problem impossible to debug.This pull req makes sure the original error message and stack trace are visible on Python 2, by appending the original exception's error message to the ModelAdminCheckException message, and re-raising the original exception's stack trace.