Compatibility fixes for Django 1.10 compatibility, stronger tests, exclude_modeladmins option #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since Django<1.8 support was dropped, so this is not tested anymore it breaks tests when queryset method is defined on modeladmin for compatibility reasons
render respose add change_view test
PetrDlouhy
force-pushed
the
master
branch
2 times, most recently
from
dc6ebda to
3d250fc
Compare
|
@SeanHayes Now I am satisfied with the PR. You can pull :-) The only line of code, that remains uncovered is exception handling from admin.autodiscover() on line 71. I can't figure out case, when this is used. |
|
Since this is still being worked on I'll post some minor change requests. |
| from django.test import TestCase | ||
| from django.test.client import RequestFactory | ||
| import sys | ||
| import django |
There was a problem hiding this comment.
Could you move this above the other django imports?
| @@ -194,12 +220,28 @@ def test_add_view(self, model, model_admin): | |||
| # make sure no errors happen here | |||
| try: | |||
| response = model_admin.add_view(request) | |||
| if response.__class__ == django.template.response.TemplateResponse: | |||
There was a problem hiding this comment.
Instead of response.__class__ ==, could you use isinstance()?
|
@SeanHayes Fixed. I have added flake8-import-order plugin to Tox checks to ensure import order in future editions. |
This was referenced Sep 9, 2016
|
@SeanHayes: Any update about this PR? All your issues are fixed. |
PetrDlouhy
force-pushed
the
master
branch
2 times, most recently
from
3d250fc to
9cc8ee2
Compare
PetrDlouhy
referenced
this pull request
in PetrDlouhy/django-admin-smoke-tests
Aug 15, 2022
…clude_modeladmins option (#8) * remove old queryset testing since Django<1.8 support was dropped, so this is not tested anymore it breaks tests when queryset method is defined on modeladmin for compatibility reasons * stronger tests render respose add change_view test * add exclude_modeladmins option * test also search request to identify bad search_fields settings * test in Django 1.10; show all warnings * fix tests in Django 1.10 * test that exceptions are raised, throw own exception class, increase coverage * include python 3.4, django 1.7 Travis test * remove old deprecated code * test and fix catching PermissionDenied exception - use it where it is needed * fix backward compatibility with Python 2.7 * print python version to ensure correct testing * test request.GET parameter * check import order with flake8; fix all import orders * use isinstance instead of __class__ * run tests with USE_TZ=True (add pytz dependency to tox) * fix tox Django version order * test also some aspects of posting change_view
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR include all three previously closed PRs. It includes following improvements:
-compatibility fixes with Django 1.10
-stronger tests
-higher test coverage and higher range of versions tested in Travis
-exclude_modeladmins option
-more detailed exception message