build: add option for sanitizers #2553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barton2526
reviewed
Jul 30, 2022
div72
force-pushed
the
sanitizers
branch
6 times, most recently
from
c2e1ef5
to
3f39cb8
Compare
Rationale:
The thread sanitizer CI job uses clang which has issues with
compiling Qt on Linux. Disable for now until the issue can be
fixed.
Rationale:
Some classes in LevelDB do not get freed unless the environment
is deleted.
Rationale:
Avoids an UB in it_rejects_invalid_claims MRC test.
The test uses reinterpret_cast<void*> on unallocated memory. Using this memory in printchunk as char* causes a segfault, so have printchunk take void* instead.
jamescowens
reviewed
Mar 6, 2024
jamescowens
added a commit
to jamescowens/Gridcoin-Research
that referenced
this pull request
Apr 10, 2024
Added - build: add option for sanitizers gridcoin-community#2553 (@div72) - build: CMake: Initial Windows support (MSYS2) gridcoin-community#2733 (@CyberTailor) Changed - build: enforce SSE2 on x86 targets gridcoin-community#2746 (@div72) - consensus: Update checkpoint data for mainnet and testnet gridcoin-community#2756 (@jamescowens) - gui, util: Enhance verify checkpoints fail handling; use RegistryBookmarks for DB passivation gridcoin-community#2758 (@jamescowens) Removed Fixed - build, depends: fix compilation with XCode 15 gridcoin-community#2747 (@div72) - Fix man page installation path for cmake builds gridcoin-community#2749 (@theMarix) - consensus, mrc, sidestake: add mrc fees to staker to rewards to be allocated via sidestaking gridcoin-community#2753 (@jamescowens) - Fix Systemd unit install location gridcoin-community#2754 (@theMarix) - scraper: Corrections to scraper_net after removal of cntPartsRcvd decrement and increment gridcoin-community#2755 (@jamescowens) - rpc: fix setban segfault gridcoin-community#2757 (@div72)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds sanitizers option and fixes the errors found in the test suite. A PR fixing the potential issues with the thread sanitizer and the issues during a normal run of the client will be made in the future.