consensus, mrc, sidestake: add mrc fees to staker to rewards to be allocated via sidestaking #2753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamescowens
changed the title
jamescowens
force-pushed
the
cleanup_mrc
branch
from
79cfae6
to
9817c60
Compare
barton2526
reviewed
Mar 18, 2024
jamescowens
force-pushed
the
cleanup_mrc
branch
from
9817c60
to
911b5c7
Compare
jamescowens
force-pushed
the
cleanup_mrc
branch
3 times, most recently
from
708661b
to
992b075
Compare
In V13 testing with simultaneous mrcs and mandatory sidestakes, stakes were being rejected because the calculated total reward to the staker did not include mrc fees. This apparently has been an existing omission, but since sidestakes were not validated it went undetected. Now that mandatory sidestakes are validated in terms of both destination and amount, they were being rejected by the validator as being too low. Adding the mrc fees due to the staker to the staker's reward fixes the problem.
jamescowens
force-pushed
the
cleanup_mrc
branch
from
992b075
to
a8899f5
Compare
jamescowens
added a commit
to jamescowens/Gridcoin-Research
that referenced
this pull request
Apr 10, 2024
Added - build: add option for sanitizers gridcoin-community#2553 (@div72) - build: CMake: Initial Windows support (MSYS2) gridcoin-community#2733 (@CyberTailor) Changed - build: enforce SSE2 on x86 targets gridcoin-community#2746 (@div72) - consensus: Update checkpoint data for mainnet and testnet gridcoin-community#2756 (@jamescowens) - gui, util: Enhance verify checkpoints fail handling; use RegistryBookmarks for DB passivation gridcoin-community#2758 (@jamescowens) Removed Fixed - build, depends: fix compilation with XCode 15 gridcoin-community#2747 (@div72) - Fix man page installation path for cmake builds gridcoin-community#2749 (@theMarix) - consensus, mrc, sidestake: add mrc fees to staker to rewards to be allocated via sidestaking gridcoin-community#2753 (@jamescowens) - Fix Systemd unit install location gridcoin-community#2754 (@theMarix) - scraper: Corrections to scraper_net after removal of cntPartsRcvd decrement and increment gridcoin-community#2755 (@jamescowens) - rpc: fix setban segfault gridcoin-community#2757 (@div72)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In V13 testing with simultaneous mrcs and mandatory sidestakes, stakes were being rejected by the reward validation because the calculated total reward to the staker used in SplitCoinStakeOutput did not include mrc fees. This apparently has been an existing omission, but since sidestakes were not validated it went undetected. Now that mandatory sidestakes are validated in terms of both destination and amount, they were being rejected by the validator as being too low.
Adding the mrc fees due to the staker to the staker's reward parameter passed to SplitCoinStakeOutput fixes the problem.
This bug is only relevant for blocks v13 and above, since mandatory sidestakes are not present in v12 and below.
Also listmandatorysidestakes has been added since the older listdata rpc call has been retired with the removal of the remainder of the appcache.