util: Implement workaround for backupwallet to deal with Boost 1.74 regression on copy_file #2669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamescowens
force-pushed
the
hotfix
branch
2 times, most recently
from
69bc5c6
to
a545184
Compare
…ver = 1.74 Note that Boost 1.74 has a known bug that causes copy_file to misbehave when use across filesystem boundaries (i.e. if the walletbackups directory is actually a symlink to somewhere else). This commit is a workaround to use std::filesystem instead for this specific operation if the wallet is linked against Boost 1.74. This can be removed when we eventually migrate to std::filesystem from boost::filesystem.
jamescowens
force-pushed
the
fix_backupwallet
branch
from
25922e5
to
cc907eb
Compare
jamescowens
added a commit
to jamescowens/Gridcoin-Research
that referenced
this pull request
Apr 5, 2023
Added - install: Enhance windows installer - detect running gridcoinresearch(d).exe and ask to close before continuing gridcoin-community#2672 (@jamescowens) - gui: Add one minute QTimer to update beacon age/expiration in tooltip gridcoin-community#2671 (@jamescowens) Changed none Removed none Fixed - util: Implement workaround for backupwallet to deal with Boost 1.74 regression on copy_file gridcoin-community#2669 (@jamescowens) - banman: use GetPerformanceCounter instead of GetRandBytes gridcoin-community#2668 (@div72)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes backupwallet to use std::filesystem for backupwallet if the wallet is running against Boost 1.74. Closes #2665.
This is tested and works on Ubuntu 22.04 with Boost 1.74, whereas the current release is confirmed to fail.