install: Enhance windows installer - detect running gridcoinresearch(d).exe and ask to close before continuing

[jamescowens]

Detect and prompt for shutdown of Gridcoin wallet during install for Windows

This commit introduces the use of ExecWait in combination with tasklist and find to detect a running Gridcoin wallet, either GUI or daemon, and prompt to shut it down before installation proceeds.

This method does not require the use of NSIS plugins, but has the disadvantage that two command windows momentarily appear during the check (one for gridcoinresearch.exe and the other for gridcoinresearchd.exe).

Closes #2662.

[barton2526]

We are willingly diverging from Bitcoin here. I think this needs some extra scrutiny...

[jamescowens]

Scrutinize away. This PR is trivial and essentially just detects whether an instance of Gridcoin is running and prompts the user to shut it down before continuing.

While we follow Bitcoin Core on many things, it doesn't mean that we are bound to stupid decisions that they make. Their installer should be doing this too.

[div72]

Approach NACK, we should not be adding binary blobs even if only to the installer.

[jamescowens]

Then we need to ensure the module is installed on the build machines for the Windows build as an alternative approach. That will work just fine. Nsprocess is a very commonly used module for this purpose and is usually available as part of the NSIS install set, although it may be in a separate package. It is on OpenSUSE. I will check on our Ubuntu OS versions we use for the build environment.

[div72]

Eh, that can do. Alternatively, https://nsis.sourceforge.io/Check_whether_your_application_is_running also lists a way to do it without plugins by using tasklist and ExecWait.

[jamescowens]

That was the very page I referenced to do this quick PR. The thing I dislike about that method is the external exec call to the tasklist. If we think that is preferable it wouldn't be too hard to use that instead. We don't support anything less than Windows 7, so it should be available for every Windows version we support.

[jamescowens]

Actually, the ExecCmd plugin has been superseded by the ExecDos plugin. I have to check whether this plugin is provided in the default NSIS packages.

[jamescowens]

The ExecDos plugin is not installed by the base NSIS package on Ubuntu. So that makes that approach equivalent in the packaging problem to my original approach.

[div72]

Wouldn't the ExecWait command work?

[jamescowens]

That will cause a command window to flash I think, which is definitely "hacky" and will raise questions.

[jamescowens]

I am going to try ExecWait, but if it repeatedly flashes command windows, I am not going to use that.

[jamescowens]

BTW this is a typical example of a BS change that is taking up an enormous amount of time. I may just close it. :|.

[jamescowens]

Hmm. I have fiddled around for several hours and cannot get ExecWait to work reliably.

This in a windows cmd does...

>"%SystemRoot%\System32\tasklist.exe" /NH /FI "IMAGENAME eq gridcoinresearch.exe" | "%SystemRoot%\System32\find.exe" /I "gridcoinresearch.exe"
gridcoinresearch.exe         32604 Console                    1  1,226,664 K

and then

>echo %errorlevel%
0

putting a purposefully non-matching exe name in the find part returns nothing and the %errorlevel% is then 1.

This part of the NSIS script should work then...

    loop:
    ExecWait '"%SystemRoot%\System32\tasklist.exe" /NH /FI \"IMAGENAME eq @GRIDCOIN_GUI_NAME@@EXEEXT@\" | "%SystemRoot%\System32\find.exe" /I \"@GRIDCOIN_GUI_NAME@@EXEEXT@\"' $0
    StrCmp $0 0 0 notRunning_gui
    MessageBox MB_OKCANCEL|MB_ICONEXCLAMATION 'The Gridcoin wallet (gridcoinresearch.exe) is running. Please close before continuing.' IDOK loop IDCANCEL end
    notRunning_gui:
    ExecWait '"%SystemRoot%\System32\tasklist.exe" /NH /FI \"IMAGENAME eq @GRIDCOIN_DAEMON_NAME@@EXEEXT@\" | "%SystemRoot%\System32\find.exe" /I \"@GRIDCOIN_DAEMON_NAME@@EXEEXT@\"' $0
    StrCmp $0 0 0 notRunning_daemon
    MessageBox MB_OKCANCEL|MB_ICONEXCLAMATION 'The Gridcoin wallet daemon (gridcoinresearchd.exe) is running. Please close before continuing.' IDOK loop IDCANCEL end
    notRunning_daemon:

But it doesn't. The ExecWaits appear to be doing nothing.

[jamescowens]

The source code for the nsProcess plugin is difficult to find. OpenSUSE has it for their OBS mingw packages, and I got it from there and can compile, but reliably downloading from source in a depends package for example is going to be difficult.

[jamescowens]

Ok. I got it to work after fiddling around with ExecWait for hours with magic incantations on the quoting... :)

[div72]

Tested ACK, seems to not work under Wine as tasklist is a stub but works on Windows.

[jamescowens]

Yeah. That doesn't surprise me and I think we can ignore that corner case. Running a wallet under WINE on Linux works of course but is more of a stunt or purely for testing of a Windows binary on a Linux machine.

[barton2526]

post merge TACK