Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try to fix CI when exceptions are disabled #116

Merged
merged 2 commits into from
Oct 16, 2019
Merged

Try to fix CI when exceptions are disabled #116

merged 2 commits into from
Oct 16, 2019

Conversation

grovesNL
Copy link
Owner

@grovesNL grovesNL commented Oct 8, 2019

Includes #115

@codecov
Copy link

codecov bot commented Oct 9, 2019 •
edited
Loading

Codecov Report

Merging #116 into master will decrease coverage by 10.75%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #116       +/-   ##
===========================================
- Coverage   48.24%   37.48%   -10.76%     
===========================================
  Files           7        7               
  Lines        1308     1243       -65     
===========================================
- Hits          631      466      -165     
- Misses        677      777      +100
Impacted Files Coverage Δ
spirv_cross/src/msl.rs 0% <0%> (-53.56%) ⬇️
spirv_cross/src/compiler.rs 75.21% <0%> (-1.86%) ⬇️
spirv_cross/src/spirv.rs 30.87% <0%> (-1.42%) ⬇️
spirv_cross/src/hlsl.rs 74.24% <0%> (-1.15%) ⬇️
spirv_cross/src/glsl.rs 89.41% <0%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2315669...733f571. Read the comment docs.

@kvark
Copy link
Contributor

kvark commented Oct 15, 2019

are we stuck on this one?

@grovesNL grovesNL force-pushed the test-ci-mingw branch 3 times, most recently from e4bf74f to 8a2e92e Compare October 16, 2019 01:11
@grovesNL
Copy link
Owner Author

bors r=kvark

bors bot added a commit that referenced this pull request Oct 16, 2019
@bors @kvark @grovesNL
Merge #116
aad647d 
116: [WIP] Try to fix CI when exceptions are disabled r=kvark a=grovesNL

Includes #115

Co-authored-by: Dzmitry Malyshau <kvarkus@gmail.com>
Co-authored-by: Joshua Groves <josh@joshgroves.com>
@bors
Copy link
Contributor

bors bot commented Oct 16, 2019

Build succeeded

@bors bors bot merged commit 733f571 into master Oct 16, 2019
@grovesNL grovesNL changed the title [WIP] Try to fix CI when exceptions are disabled Try to fix CI when exceptions are disabled Oct 16, 2019
@grovesNL grovesNL deleted the test-ci-mingw branch October 16, 2019 12:37
@kvark kvark mentioned this pull request Nov 6, 2019
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvark kvark kvark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grovesNL @kvark