Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc.request.deadline and grpc.start_time precision is in seconds #131

Closed
matiasanaya opened this issue Feb 27, 2018 · 2 comments · Fixed by #398
Closed

grpc.request.deadline and grpc.start_time precision is in seconds #131

matiasanaya opened this issue Feb 27, 2018 · 2 comments · Fixed by #398
Labels
enhancement

Comments

@matiasanaya
Copy link
Contributor

matiasanaya commented Feb 27, 2018 •
edited
Loading

grpc.request.deadline and grpc.start_time use d.Format(time.RFC3339) which means maximum precision is in seconds. I believe it would be useful to use d.Format(time.RFC3339Nano) at least.

Best would be a configuration option for me to format all logged timestamps as desired.

I can work on a PR for this change if it makes sense.
@mwitkow
Copy link
Member

mwitkow commented Mar 31, 2018

@domgreen you made tracking of the elapsed time, right? It's probably best for you to take this.

@mwitkow mwitkow assigned mwitkow and unassigned mwitkow Mar 31, 2018
stanhu added a commit to stanhu/go-grpc-middleware that referenced this issue Feb 12, 2021
@stanhu
Support customization of timestamp format
5431b3e 
By default, RFC3339 timestamps are used, but our application uses a
custom format. This commit enables us to set the format in a consistent
manner.

Closes grpc-ecosystem#131
@stanhu stanhu mentioned this issue Feb 12, 2021
Merged
stanhu added a commit to stanhu/go-grpc-middleware that referenced this issue Feb 12, 2021
@stanhu
Support customization of timestamp format
67de517 
By default, RFC3339 timestamps are used, but our application uses a
custom format. This commit enables us to set the format in a consistent
manner.

Closes grpc-ecosystem#131
@stanhu
Copy link
Contributor

stanhu commented Feb 12, 2021

Can someone review #398?

johanbrandhorst pushed a commit that referenced this issue Feb 13, 2021
@stanhu
Support customization of timestamp format (#398)
be4c235 
By default, RFC3339 timestamps are used, but our application uses a
custom format. This commit enables us to set the format in a consistent
manner.

Closes #131
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support customization of timestamp format stanhu/go-grpc-middleware
3 participants
@stanhu @matiasanaya @mwitkow