-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support customization of timestamp format #398
Support customization of timestamp format #398
Conversation
By default, RFC3339 timestamps are used, but our application uses a custom format. This commit enables us to set the format in a consistent manner. Closes grpc-ecosystem#131
5431b3e
to
67de517
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for your contribution! Could you please cherry pick this against v2? It may need significant refactoring but it'd be good to have in the new version too. |
@johanbrandhorst Sure, I took a look at the v2 branch. It looks like the new payload interceptors have a bit different signature from go-grpc-middleware/interceptors/logging/payload.go Lines 126 to 148 in c1f1e53
It doesn't seem like we can reuse
|
CC @bwplotka |
This ports grpc-ecosystem#398 to the v2 branch.
This ports grpc-ecosystem#398 to the v2 branch.
I did the simplest thing with option 2 in #399, but I don't love it. Feel free to refactor as necessary. |
This ports #398 to the v2 branch.
By default, RFC3339 timestamps are used, but our application uses a
custom format. This commit enables us to set the format in a consistent
manner.
Closes #131