Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc-go library can return errors not allowed by the specification #1162

Closed
dfawley opened this issue Mar 31, 2017 · 1 comment
Closed

grpc-go library can return errors not allowed by the specification #1162

dfawley opened this issue Mar 31, 2017 · 1 comment
Assignees
@jeanbza
Labels
P2 Type: Bug

Comments

@dfawley
Copy link
Member

dfawley commented Mar 31, 2017

From:

https://github.com/grpc/grpc/blob/master/doc/statuscodes.md

we should not be returning errors like InvalidArgument or NotFound. However, there is code in grpc-go that could potentially return several of these. We should fix this and change the error codes returned when those conditions occur.
@dfawley dfawley added Type: API Change Breaking API changes (experimental APIs only!) bug labels Mar 31, 2017
@dfawley dfawley self-assigned this Mar 31, 2017
@dfawley dfawley mentioned this issue Sep 1, 2017
Closed
@dfawley dfawley added P2 and removed Type: API Change Breaking API changes (experimental APIs only!) labels Oct 12, 2017
@dfawley dfawley assigned jeanbza and unassigned dfawley Mar 12, 2018
@jeanbza
Copy link
Member

jeanbza commented Mar 12, 2018 •
edited
Loading

Also closed #1672 (seems to be similar)

@jeanbza jeanbza closed this as completed Mar 12, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Sep 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jeanbza jeanbza

Labels
P2 Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeanbza @dfawley