-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Out-of-range status codes should be coalesced to "UNKNOWN" #1672
Comments
- Per https://github.com/grpc/grpc/blob/9d0bc30edbe14fef58f32e74009dd513dee2cfd0/doc/statuscodes.md, NOT_FOUND should not be returned by the library - Relevant issue: grpc#1672
- Per https://github.com/grpc/grpc/blob/9d0bc30edbe14fef58f32e74009dd513dee2cfd0/doc/statuscodes.md, INVALID_ARGUMENT should not be returned by the library - Relevant issue: grpc#1672
- Per https://github.com/grpc/grpc/blob/9d0bc30edbe14fef58f32e74009dd513dee2cfd0/doc/statuscodes.md, DATA_LOSS and FAILED_PRECONDITION should not be returned by the library - Relevant issue: grpc#1672
The linked PRs should cover all codes. There were many instances of the first two codes in the list (NOT_FOUND, INVALID_ARGUMENT) which is why I created separate PRs, but then the rest of the errors had hardly any occurrences heh. Oh well. Let me know if you'd like me to merge them. |
@menghanl I believe this is finished, now |
@jadekler we still return unexpected code in function Lines 76 to 85 in 583a630
|
Shoot good point. I'll fix that tn |
- convertCode utilized errors that were not allowed by the library per https://github.com/grpc/grpc/blob/9d0bc30edbe14fef58f32e74009dd513dee2cfd0/doc/statuscodes.md - Relevant issue: grpc#1672
- convertCode utilized errors that were not allowed by the library per https://github.com/grpc/grpc/blob/9d0bc30edbe14fef58f32e74009dd513dee2cfd0/doc/statuscodes.md - Relevant issue: grpc#1672
- convertCode utilized errors that were not allowed by the library per https://github.com/grpc/grpc/blob/9d0bc30edbe14fef58f32e74009dd513dee2cfd0/doc/statuscodes.md - Relevant issue: grpc#1672
- convertCode utilized errors that were not allowed by the library per https://github.com/grpc/grpc/blob/9d0bc30edbe14fef58f32e74009dd513dee2cfd0/doc/statuscodes.md - Relevant issue: grpc#1672
- convertCode utilized errors that were not allowed by the library per https://github.com/grpc/grpc/blob/9d0bc30edbe14fef58f32e74009dd513dee2cfd0/doc/statuscodes.md - Relevant issue: #1672
- convertCode utilized errors that were not allowed by the library per https://github.com/grpc/grpc/blob/9d0bc30edbe14fef58f32e74009dd513dee2cfd0/doc/statuscodes.md - Relevant issue: grpc#1672
Per grpc/grpc#13321 (comment), we should not set the status code to an out-of-range value; we should force it to UNKNOWN when that happens instead.
The text was updated successfully, but these errors were encountered: