Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolver: should adds a NOTE to SetDefaultScheme like Register? #2216

Closed
chanxuehong opened this issue Jul 13, 2018 · 1 comment · Fixed by #2217
Closed

resolver: should adds a NOTE to SetDefaultScheme like Register? #2216

chanxuehong opened this issue Jul 13, 2018 · 1 comment · Fixed by #2217
Assignees
Labels
P2 Type: Documentation Documentation or examples

Comments

@chanxuehong
Copy link

chanxuehong commented Jul 13, 2018

https://github.com/grpc/grpc-go/blob/master/resolver/resolver.go#L54

for SetDefaultScheme is not thread-safe, should we adds a NOTE link Register:

// NOTE: this function must only be called during initialization time (i.e. in
// an init() function), and is not thread-safe. If multiple Resolvers are

@dfawley
Copy link
Member

dfawley commented Jul 13, 2018

Yes, that makes sense, thanks for the suggestion.

@dfawley dfawley added the Type: Documentation Documentation or examples label Jul 13, 2018
@dfawley dfawley added the P2 label Jul 13, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P2 Type: Documentation Documentation or examples
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants