addrConn: Report underlying connection error in RPC error #1855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
approved these changes
Feb 13, 2018
…ils because of TransientFailure.
menghanl
force-pushed
the
rpc_error_connection_reason
branch
from
6f367c6
to
cf04d2c
Compare
menghanl
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only happens when the RPC failed because all addrConn was in TransientFailure. And this is best effort because the returned error might not be the real cause.
But it should be good enough to detect the reason when the ClientConn is "dead" (keep retrying but none of the connection works).
This is not a perfect solution because it's racy. But this should be a good workaround for most cases.
An ultimate solution would be to pass the errors as part of the connectivity state information to the balancers, and balancers pass those errors back to RPCs as a pick result. This would need API changes on balancers.
updates #1742
fixes #1633
fixes #1656