Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

channelz: stage 4 - add security and socket option info with appengine build tags #2149

Merged
merged 5 commits into from
Jun 25, 2018
Merged

channelz: stage 4 - add security and socket option info with appengine build tags #2149

merged 5 commits into from
Jun 25, 2018

Conversation

lyuxuan
Copy link
Contributor

@lyuxuan lyuxuan commented Jun 14, 2018

No description provided.

@lyuxuan lyuxuan merged commit 7268ca4 into grpc:master Jun 25, 2018
@jittuu
Copy link

jittuu commented Jun 26, 2018

@lyuxuan I think you miss !appengine build flag on credentials_util_go19.go file. I still got bad import "syscall" error on appengine. Thanks.

@dfawley dfawley added the Type: Feature New features or improvements in behavior label Jun 28, 2018
@dfawley dfawley added this to the 1.14 Release milestone Jun 28, 2018
@menghanl menghanl changed the title channelz: stage 4 - add security and socket option info with appengine build tags channelz: stage 4 - add security and socket option info with appengine build tags Jul 17, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees
No one assigned
Labels
Type: Feature New features or improvements in behavior
Projects
None yet
Milestone
1.14 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@lyuxuan @jittuu @dfawley