balancer: add rpc method to PickOptions #2204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide additional context to Pickers that wish to make decisions based on the RPC method
menghanl
reviewed
Jul 10, 2018
balancer/balancer.go
Outdated
| @@ -143,7 +143,10 @@ type Builder interface { | |||
| } | |||
|
|
|||
| // PickOptions contains addition information for the Pick operation. | |||
| type PickOptions struct{} | |||
| type PickOptions struct { | |||
| // FullMethodName is the full method name of the RPC. | |||
There was a problem hiding this comment.
Explain a bit more on this? E.g.
FullMethodName is the method name that NewStream() is called with, the canonical format is /service/method.
menghanl
reviewed
Jul 10, 2018
|
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
mfycheng
force-pushed
the
add-method-to-pickoptions
branch
from
41ff5a3 to
477ac82
Compare
|
Added more context to the |
menghanl
approved these changes
Jul 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide additional context to Pickers that wish to make decisions based on the RPC method.
Relevant issue: #2103