Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

errors: convert io.ErrUnexpectedEOF to a codes.Internal status error #2228

Merged
merged 1 commit into from
Jul 18, 2018
Merged

errors: convert io.ErrUnexpectedEOF to a codes.Internal status error #2228

merged 1 commit into from
Jul 18, 2018

Conversation

dsymonds
Copy link
Contributor

This is consistent with how io.ErrUnexpectedEOF is handled in a bunch of
other places (e.g. stream.go, server.go), and signals to
application-level code that the error is retryable.

…CErr.

This is consistent with how io.ErrUnexpectedEOF is handled in a bunch of
other places (e.g. stream.go, server.go), and signals to
application-level code that the error is retryable.
@thelinuxfoundation
Copy link

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
CLA GitHub bot

@dfawley
Copy link
Member

dfawley commented Jul 17, 2018

Thanks for the fix @dsymonds. Could you make sure you accept the CLA, please? The project is CNCF, now, so there are new CLAs to sign, unfortunately.

@dsymonds
Copy link
Contributor Author

I should be covered by the Google corporate CLA for this. I've reached out to the OSPO to find out what they need to do from their end to fix the automation here; did you want to wait for that, or verify me OOB?

@dfawley
Copy link
Member

dfawley commented Jul 17, 2018

@dsymonds You will need to sign up at linuxfoundation.org for the CLAs to be satisfied. Everyone on the grpc team at google had to do this. Steps:

  • https://identity.linuxfoundation.org/projects/cncf
  • Click "Sign up ... as an employee"
  • Sign in with your @google.com account
  • (This is from an old email; I hope it's accurate): Use "add identity" and associate your github account with your new linux foundation account.
  • Drop a comment here to kick the CLA check

@dsymonds
Copy link
Contributor Author

I did that already, but signed in with my GitHub account. I guess that was the wrong move.

I've done it again but with my google.com Google account. It looks like the new thing is "Social network logins" (wat). However, since I previously signed in via my GitHub account, I can't add that to this new account ("This identity is registered to another user."). I signed back in with my GitHub account, but now can't add my google.com Google account for the same reason ("This identity is registered to another user."). Their interface doesn't seem to let me delete either account, or even delete the identity for the account so I can use it on the other. I seem to be stuck.

@dsymonds
Copy link
Contributor Author

I thought I might be able to add a second Google account (e.g. my personal gmail) to one, then delete the primary identity, but it seems the linuxfoundation interface only works with one of each kind of identity. I don't have Facebook or OpenStack accounts, and the only other options are GitHub and Google accounts, and I've used both of those. D'oh.

@dfawley
Copy link
Member

dfawley commented Jul 17, 2018

@jtattermusch @hsaliak any idea what is going on here and how to fix it?

@jtattermusch
Copy link
Contributor

@dsymonds I'm going to take a guess: The commit logs for this PR show your committer email as *****@golang.org - perhaps you should change that to the e-mail address known to the CLA checker? AFAIK the CLA checkers usually go by the e-mail address to recognize users.

@dsymonds
Copy link
Contributor Author

@jtattermusch: But I don't want to author my commits with a different email address. It should work with alternate addresses, which it does, except that I can no longer get to a state where I have multiple addresses registered with a linuxfoundation CLA account.

@dsymonds
Copy link
Contributor Author

Anyway, the OSPO got back to me and said I could sign the individual CLA, making this moot.

@thelinuxfoundation: Check the CLA again please.

@dsymonds
Copy link
Contributor Author

@dfawley: CLA check is passing now.

@dfawley
Copy link
Member

dfawley commented Jul 18, 2018

Cool, thanks for resolving the CLA issue.

@dfawley dfawley merged commit 5562178 into grpc:master Jul 18, 2018
@dsymonds dsymonds deleted the unexpected-eof branch July 18, 2018 22:25
@menghanl menghanl added this to the 1.14 Release milestone Jul 20, 2018
@menghanl menghanl changed the title Convert io.ErrUnexpectedEOF to a codes.Internal-marked status in toRPCerr. errors: convert io.ErrUnexpectedEOF to a codes.Internal status error Jul 25, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants