-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
errors: convert io.ErrUnexpectedEOF to a codes.Internal status error #2228
Conversation
…CErr. This is consistent with how io.ErrUnexpectedEOF is handled in a bunch of other places (e.g. stream.go, server.go), and signals to application-level code that the error is retryable.
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
Thanks for the fix @dsymonds. Could you make sure you accept the CLA, please? The project is CNCF, now, so there are new CLAs to sign, unfortunately. |
I should be covered by the Google corporate CLA for this. I've reached out to the OSPO to find out what they need to do from their end to fix the automation here; did you want to wait for that, or verify me OOB? |
@dsymonds You will need to sign up at linuxfoundation.org for the CLAs to be satisfied. Everyone on the grpc team at google had to do this. Steps:
|
I did that already, but signed in with my GitHub account. I guess that was the wrong move. I've done it again but with my google.com Google account. It looks like the new thing is "Social network logins" (wat). However, since I previously signed in via my GitHub account, I can't add that to this new account ("This identity is registered to another user."). I signed back in with my GitHub account, but now can't add my google.com Google account for the same reason ("This identity is registered to another user."). Their interface doesn't seem to let me delete either account, or even delete the identity for the account so I can use it on the other. I seem to be stuck. |
I thought I might be able to add a second Google account (e.g. my personal gmail) to one, then delete the primary identity, but it seems the linuxfoundation interface only works with one of each kind of identity. I don't have Facebook or OpenStack accounts, and the only other options are GitHub and Google accounts, and I've used both of those. D'oh. |
@jtattermusch @hsaliak any idea what is going on here and how to fix it? |
@dsymonds I'm going to take a guess: The commit logs for this PR show your committer email as |
@jtattermusch: But I don't want to author my commits with a different email address. It should work with alternate addresses, which it does, except that I can no longer get to a state where I have multiple addresses registered with a linuxfoundation CLA account. |
Anyway, the OSPO got back to me and said I could sign the individual CLA, making this moot. @thelinuxfoundation: Check the CLA again please. |
@dfawley: CLA check is passing now. |
Cool, thanks for resolving the CLA issue. |
This is consistent with how io.ErrUnexpectedEOF is handled in a bunch of
other places (e.g. stream.go, server.go), and signals to
application-level code that the error is retryable.