Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example: multiplex #2477

Merged
merged 4 commits into from
Dec 6, 2018
Merged

example: multiplex #2477

merged 4 commits into from
Dec 6, 2018

Conversation

menghanl
Copy link
Contributor

@menghanl menghanl commented Dec 4, 2018 •
edited
Loading

Show that a channel can be shared by two stubs and two services can share a
server.

fixes #2486

@menghanl menghanl requested a review from dfawley December 5, 2018 01:40
dfawley
dfawley approved these changes Dec 5, 2018
View reviewed changes
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I do think we should test these (can be added later) to make sure they don't stop working.

examples/features/multiplex/README.md Outdated Show resolved Hide resolved
examples/features/multiplex/README.md Outdated Show resolved Hide resolved
@menghanl
example: multiplex
0d224b3 
Show that a channel can be shared by two stubs and two servicers can share a
server.
@menghanl
use echo
156a7e3
@menghanl
readme
9e79127
dfawley
dfawley approved these changes Dec 6, 2018
View reviewed changes
examples/features/multiplex/README.md Outdated Show resolved Hide resolved
examples/features/multiplex/client/main.go Outdated Show resolved Hide resolved
@dfawley dfawley assigned menghanl and unassigned dfawley Dec 6, 2018
@menghanl menghanl merged commit 187e357 into grpc:master Dec 6, 2018
@menghanl menghanl deleted the example-sharing branch December 6, 2018 22:02
@dfawley dfawley added the Type: Documentation Documentation or examples label Dec 13, 2018
@dfawley dfawley added this to the 1.18 Release milestone Dec 13, 2018
@menghanl menghanl changed the title examples: multiplex example: multiplex Jan 15, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jul 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees

@menghanl menghanl

Labels
Type: Documentation Documentation or examples
Projects
None yet
Milestone
1.18 Release
Development

Successfully merging this pull request may close these issues.

examples: channel/server sharing
2 participants
@menghanl @dfawley