Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example: deadline #2494

Merged
merged 11 commits into from
Dec 14, 2018
Merged

example: deadline #2494

merged 11 commits into from
Dec 14, 2018

Conversation

canguler
Copy link

@canguler canguler commented Dec 4, 2018 •
edited by dfawley
Loading

Fixes #2481

@canguler canguler requested a review from dfawley December 4, 2018 19:41
@menghanl menghanl changed the title Examples/deadline Examples: deadline Dec 5, 2018
dfawley
dfawley reviewed Dec 5, 2018
View reviewed changes
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move everything into examples/features/deadline/...

examples/deadline/client/client.go Outdated Show resolved Hide resolved
examples/deadline/client/client.go Outdated Show resolved Hide resolved
examples/deadline/client/client.go Outdated Show resolved Hide resolved
examples/deadline/servermain/server.go Outdated Show resolved Hide resolved
@menghanl menghanl changed the title Examples: deadline examples: deadline Dec 5, 2018
@dfawley dfawley assigned canguler and unassigned dfawley Dec 6, 2018
@canguler canguler assigned dfawley and unassigned canguler Dec 7, 2018
dfawley
dfawley reviewed Dec 12, 2018
View reviewed changes
examples/features/deadline/client/main.go Show resolved Hide resolved
examples/features/deadline/client/main.go Outdated Show resolved Hide resolved
examples/features/deadline/server/main.go Show resolved Hide resolved
examples/features/deadline/server/main.go Outdated Show resolved Hide resolved
examples/features/deadline/server/main.go Outdated Show resolved Hide resolved
examples/features/deadline/server/main.go Outdated Show resolved Hide resolved
examples/features/deadline/server/main.go Outdated Show resolved Hide resolved
examples/features/deadline/server/main.go Outdated Show resolved Hide resolved
examples/features/deadline/server/main.go Outdated Show resolved Hide resolved
examples/features/deadline/server/main.go Outdated Show resolved Hide resolved
@dfawley dfawley assigned canguler and unassigned dfawley Dec 12, 2018
@canguler canguler assigned canguler and dfawley and unassigned canguler Dec 12, 2018
dfawley
dfawley approved these changes Dec 14, 2018
View reviewed changes
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few small things.

examples/features/deadline/server/main.go Outdated Show resolved Hide resolved
examples/features/deadline/server/main.go Outdated Show resolved Hide resolved
examples/features/deadline/client/main.go Show resolved Hide resolved
@dfawley dfawley assigned canguler and unassigned dfawley Dec 14, 2018
@canguler canguler merged commit 42df0c5 into grpc:master Dec 14, 2018
@dfawley dfawley changed the title examples: deadline example: deadline Dec 20, 2018
@dfawley dfawley added Type: Documentation Documentation or examples and removed Type: Documentation Documentation or examples labels Dec 20, 2018
@dfawley dfawley added this to the 1.18 Release milestone Dec 20, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jun 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees

@canguler canguler

Labels
Type: Documentation Documentation or examples
Projects
None yet
Milestone
1.18 Release
Development

Successfully merging this pull request may close these issues.

examples: deadline
2 participants
@canguler @dfawley