example: metadata #2500
Merged
example: metadata #2500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
reviewed
Dec 5, 2018
| } | ||
| } | ||
|
|
||
| func serverStreamingWithMetadata(c pb.GreeterClient, names []string) { |
There was a problem hiding this comment.
Do we need examples for all the various stream types? Setting/reading metadata should be the same for all of them, right?
dfawley
reviewed
Dec 6, 2018
menghanl
force-pushed
the
metadata_code
branch
from
7beef85 to
846d544
Compare
dfawley
reviewed
Dec 7, 2018
| for i, e := range t { | ||
| fmt.Printf(" %d. %s\n", i, e) | ||
| } | ||
| } |
There was a problem hiding this comment.
Either:
-
else { log.Fatal() }, or -
remove the
ifand just assume it's present. Actually this will work and not output anything if it's missing, since werangeovert, and ranging over anilslice is fine.
In the second case...nothing bad happens if things are broken and the metadata is not present. Is that OK?
dfawley
approved these changes
Dec 11, 2018
dfawley
reviewed
Dec 12, 2018
dfawley
reviewed
Dec 12, 2018
| if err != nil { | ||
| log.Fatalf("failed to listen: %v", err) | ||
| } | ||
| fmt.Printf("server listening at port %v\n", port) | ||
| fmt.Printf("server listening at port %v\n", *port) |
There was a problem hiding this comment.
In case port is zero, print lis.Addr()?
dfawley
added
Type: Documentation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2480