Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example: wait_for_ready #2503

Merged
merged 9 commits into from
Dec 14, 2018
Merged

example: wait_for_ready #2503

merged 9 commits into from
Dec 14, 2018

Conversation

canguler
Copy link

@canguler canguler commented Dec 5, 2018

No description provided.

@canguler canguler requested a review from menghanl December 5, 2018 23:17
@canguler canguler assigned canguler and menghanl and unassigned canguler Dec 5, 2018
@menghanl menghanl changed the title examples/wait_for_ready examples: wait_for_ready Dec 5, 2018
menghanl
menghanl reviewed Dec 11, 2018
View reviewed changes
examples/features/wait_for_ready/main.go Show resolved Hide resolved
examples/features/wait_for_ready/main.go Outdated Show resolved Hide resolved
examples/features/wait_for_ready/main.go Outdated Show resolved Hide resolved
examples/features/wait_for_ready/main.go Outdated Show resolved Hide resolved
menghanl
menghanl approved these changes Dec 13, 2018
View reviewed changes
rpc_util.go Outdated Show resolved Hide resolved
@dfawley dfawley assigned canguler and unassigned menghanl Dec 13, 2018
menghanl
menghanl approved these changes Dec 13, 2018
View reviewed changes
Copy link
Contributor

@menghanl menghanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@canguler canguler merged commit b74673a into grpc:master Dec 14, 2018
@canguler
Copy link
Author

fixes #2490

@dfawley dfawley changed the title examples: wait_for_ready example: wait_for_ready Dec 20, 2018
@dfawley dfawley added Type: Documentation Documentation or examples and removed Type: Documentation Documentation or examples labels Dec 20, 2018
@dfawley dfawley added this to the 1.18 Release milestone Dec 20, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jun 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@menghanl menghanl menghanl approved these changes

Assignees

@canguler canguler

Labels
Type: Documentation Documentation or examples
Projects
None yet
Milestone
1.18 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@canguler @menghanl @dfawley