example: add echo proto #2505
Merged
example: add echo proto #2505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
reviewed
Dec 6, 2018
|
|
||
| syntax = "proto3"; | ||
|
|
||
| package echo; |
There was a problem hiding this comment.
grpc.examples.features.proto.echo ?
grpc.examples.echo ?
There was a problem hiding this comment.
grpc.examples.echo should be good.
I didn't add option go_package = , I think we don't need it for this.
There was a problem hiding this comment.
And the directory name needs to be renamed to grpc_examples_echo, to match the go package name.
menghanl
force-pushed
the
example-echo
branch
from
3331374 to
726d265
Compare
dfawley
approved these changes
Dec 6, 2018
This reverts commit 4bdea41.
dfawley
approved these changes
Dec 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.