health: shutdown server to set NOT_SERVING and disallow future updates #2513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
approved these changes
Dec 7, 2018
| @@ -110,7 +117,14 @@ func (s *Server) Watch(in *healthpb.HealthCheckRequest, stream healthgrpc.Health | |||
| func (s *Server) SetServingStatus(service string, servingStatus healthpb.HealthCheckResponse_ServingStatus) { | |||
| s.mu.Lock() | |||
| defer s.mu.Unlock() | |||
| if s.shutdownEvent.HasFired() { | |||
There was a problem hiding this comment.
I think this could go above the lock. (?)
There was a problem hiding this comment.
There can be a race if this is not in the lock
goroutine-1: HasFired()=false
goroutine-2: Fire()
goroutine-2: take lock, set Not_serving, release lock
goroutine-1: take lock, set status (to Serving)
health/server_internal_test.go
Outdated
| s := NewServer() | ||
| s.SetServingStatus(testService, healthpb.HealthCheckResponse_SERVING) | ||
|
|
||
| s.mu.Lock() |
There was a problem hiding this comment.
There is nothing asynchronous happening, so I don't think this needs a lock. Remove the status local entirely maybe?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.