Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

example: name_resolving #2514

Merged
merged 3 commits into from
Dec 27, 2018
Merged

example: name_resolving #2514

merged 3 commits into from
Dec 27, 2018

Conversation

menghanl
Copy link
Contributor

@menghanl menghanl commented Dec 7, 2018

fixes #2493

menghanl
menghanl commented Dec 21, 2018
View reviewed changes
Copy link
Contributor Author

@menghanl menghanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments resolved. PTAL.

@menghanl menghanl merged commit 36f3126 into grpc:master Dec 27, 2018
@menghanl menghanl deleted the example-resolver branch December 27, 2018 22:30
@menghanl menghanl added the Type: Documentation Documentation or examples label Dec 27, 2018
@menghanl menghanl added this to the 1.18 Release milestone Dec 27, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jun 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lyuxuan lyuxuan lyuxuan approved these changes

Assignees

@lyuxuan lyuxuan

Labels
Type: Documentation Documentation or examples
Projects
None yet
Milestone
1.18 Release
Development

Successfully merging this pull request may close these issues.

examples: name resolution
2 participants
@menghanl @lyuxuan