Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

health: resume health server #2528

Merged
merged 2 commits into from
Dec 26, 2018
Merged

health: resume health server #2528

merged 2 commits into from
Dec 26, 2018

Conversation

menghanl
Copy link
Contributor

No description provided.

@menghanl menghanl requested a review from dfawley December 19, 2018 01:37
dfawley
dfawley approved these changes Dec 19, 2018
View reviewed changes
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the title be: "internal: change health server shutdown event to a bool and add logging" or something like that?

@dfawley dfawley assigned menghanl and unassigned dfawley Dec 20, 2018
@menghanl menghanl changed the title health: restart health server health: resume health server Dec 20, 2018
@menghanl menghanl merged commit 7b14136 into grpc:master Dec 26, 2018
@menghanl menghanl deleted the health_restart branch December 26, 2018 18:44
@menghanl menghanl added this to the 1.18 Release milestone Dec 27, 2018
@menghanl menghanl added the Type: Feature New features or improvements in behavior label Dec 27, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jun 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees

@menghanl menghanl

Labels
Type: Feature New features or improvements in behavior
Projects
None yet
Milestone
1.18 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@menghanl @dfawley