Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: make handshake required 'on' by default, not 'hybrid' #2565

Merged
merged 1 commit into from
Jan 15, 2019
Merged

client: make handshake required 'on' by default, not 'hybrid' #2565

merged 1 commit into from
Jan 15, 2019

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Jan 14, 2019

cc #2406

@dfawley dfawley requested a review from menghanl January 14, 2019 23:35
@dfawley dfawley merged commit 6cc789b into grpc:master Jan 15, 2019
@dfawley dfawley deleted the hybridoffbydefault branch January 15, 2019 17:43
@menghanl menghanl added the Type: Behavior Change Behavior changes not categorized as bugs label Jan 15, 2019
@menghanl menghanl added this to the 1.18 Release milestone Jan 15, 2019
@dfawley dfawley mentioned this pull request Jan 23, 2019
Closed
@menghanl menghanl mentioned this pull request Feb 28, 2019
Closed
@draffensperger draffensperger mentioned this pull request Mar 26, 2019
Merged
@dfawley
Copy link
Member Author

dfawley commented Apr 1, 2019

PSA: the missing fallthrough was fixed by #2603.

@lock lock bot locked as resolved and limited conversation to collaborators Sep 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@menghanl menghanl menghanl approved these changes

Assignees

@menghanl menghanl

Labels
Type: Behavior Change Behavior changes not categorized as bugs
Projects
None yet
Milestone
1.18 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@dfawley @menghanl