Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transport: remove defer in http2Client.getStream #2980

Merged
merged 1 commit into from
Aug 15, 2019
Merged

transport: remove defer in http2Client.getStream #2980

merged 1 commit into from
Aug 15, 2019

Conversation

dzbarsky
Copy link
Contributor

The code is simple enough, the defer is pure cost.

@dfawley dfawley changed the title Improve http2Client.getStream transport: remove defer in http2Client.getStream Aug 15, 2019
@dfawley dfawley added the Type: Performance Performance improvements (CPU, network, memory, etc) label Aug 15, 2019
@dfawley dfawley added this to the 1.24.0 milestone Aug 15, 2019
dfawley
dfawley approved these changes Aug 15, 2019
View reviewed changes
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also be able to remove the ", ok" here and use stream == nil to signal ok instead, which I think would be an improvement. But we can do that separately if it does make sense to do.

@dfawley dfawley merged commit 0308245 into grpc:master Aug 15, 2019
easwars added a commit to easwars/grpc-go that referenced this pull request Aug 16, 2019
@easwars
transport: make http2Client.getStream() to only return a stream.
9e814e4 
Suggested in grpc#2980.
@easwars easwars mentioned this pull request Aug 16, 2019
Merged
easwars added a commit that referenced this pull request Aug 16, 2019
@easwars
transport: make http2Client.getStream() to only return a stream. (#2984)
c26cd97 
Suggested in #2980.
@lock lock bot locked as resolved and limited conversation to collaborators Feb 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees
No one assigned
Labels
Type: Performance Performance improvements (CPU, network, memory, etc)
Projects
None yet
Milestone
1.24 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@dzbarsky @dfawley