Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal: update proto library version #3025

Merged
merged 4 commits into from
Sep 17, 2019
Merged

internal: update proto library version #3025

merged 4 commits into from
Sep 17, 2019

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Sep 17, 2019 •
edited
Loading

Also, two fixes:

  • Fix long-standing .travis.yml bug where VET_SKIP_PROTO was not exported (so not seen by vet.sh).
  • Update vet.sh to work with new goimports -l that does not print a : after filenames.

cc: #3024

@dfawley dfawley added the Type: Dependencies Updating/adding/removing dependencies label Sep 17, 2019
@dfawley dfawley added this to the 1.24 Release milestone Sep 17, 2019
@dfawley
Copy link
Member Author

dfawley commented Sep 17, 2019

Note: when making sure vet.sh would test the protos now (vs. waiting until the cron run), I noticed that we always have been checking protos in our presubmits, even though we were trying to skip those checks.

@dfawley dfawley mentioned this pull request Sep 17, 2019
Closed
@dfawley dfawley merged commit e2cfd1c into grpc:master Sep 17, 2019
@dfawley dfawley deleted the protoc branch September 17, 2019 20:49
@lock lock bot locked as resolved and limited conversation to collaborators Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@menghanl menghanl menghanl approved these changes

Assignees

@menghanl menghanl

Labels
Type: Dependencies Updating/adding/removing dependencies
Projects
None yet
Milestone
1.24 Release
Development

Successfully merging this pull request may close these issues.
2 participants
@dfawley @menghanl