Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: consider service config invalid if loadBalancingConfig contains no supported policy #3034

Merged
merged 3 commits into from
Sep 20, 2019

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Sep 20, 2019

If loadBalancingConfig is not specified in the service config, this has no effect.

Relevant part of gRFC:

message ServiceConfig {
...
  // Multiple LB policies can be specified; clients will iterate through
  // the list in order and stop at the first policy that they support. If none
  // are supported, the service config is considered invalid.
  repeated LoadBalancingConfig load_balancing_config = 4;
}

@dfawley dfawley added this to the 1.24 Release milestone Sep 20, 2019
@dfawley
Copy link
Member Author

dfawley commented Sep 20, 2019

cc @ejona86 @markdroth FYI

@dfawley dfawley merged commit 6b46f47 into grpc:master Sep 20, 2019
@dfawley dfawley deleted the lbConfigExhaustion branch September 20, 2019 23:07
@lock lock bot locked as resolved and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants