Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: use "localhost:port" as authority if target is ":port" #4017

Merged
merged 8 commits into from
Nov 12, 2020
Merged

client: use "localhost:port" as authority if target is ":port" #4017

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b82a372
Implemented fix
GarrettGutierrez1 Nov 5, 2020
16bcbdc
removed empty auth fix
GarrettGutierrez1 Nov 5, 2020
34b5d5c
Added test for localhost:port authority.
GarrettGutierrez1 Nov 11, 2020
e41f1ae
Refactored testing
GarrettGutierrez1 Nov 11, 2020
0ca3dba
Refactored testing, added lock
GarrettGutierrez1 Nov 12, 2020
1132a36
Moved mutex call
GarrettGutierrez1 Nov 12, 2020
080bc24
s[1]->port
GarrettGutierrez1 Nov 12, 2020
f700819
Merge branch 'master' into port-authority-header-fix
GarrettGutierrez1 Nov 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions clientconn.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,6 +259,8 @@ func DialContext(ctx context.Context, target string, opts ...DialOption) (conn *
cc.authority = cc.dopts.authority
} else if strings.HasPrefix(cc.target, "unix:") {
cc.authority = "localhost"
} else if strings.HasPrefix(cc.parsedTarget.Endpoint, ":") {
cc.authority = "localhost" + cc.parsedTarget.Endpoint
} else {
// Use endpoint from "scheme://authority/endpoint" as the default
// authority for ClientConn.
Expand Down