Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protoc-gen-go-grpc: Fixed option typo in README.md file #5158

Closed
wants to merge 2 commits into from
Closed

protoc-gen-go-grpc: Fixed option typo in README.md file #5158

wants to merge 2 commits into from

Conversation

eko
Copy link

@eko eko commented Jan 21, 2022 •
edited by menghanl
Loading

RELEASE NOTES: N/A

menghanl
menghanl approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@menghanl menghanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. LGTM.

@menghanl menghanl requested a review from dfawley January 21, 2022 18:08
@menghanl menghanl added the Type: Documentation Documentation or examples label Jan 21, 2022
@menghanl menghanl added this to the 1.45 Release milestone Jan 21, 2022
dfawley
dfawley requested changes Jan 21, 2022
View reviewed changes
Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is wrong. The opt flag doesn't accept :<output_location> at the end, does it? What error are you getting when you use it as documented?

@dfawley dfawley assigned eko and unassigned dfawley Jan 21, 2022
@eko
Copy link
Author

eko commented Jan 21, 2022

Hi,

You're right, I didn't see the . at the end, I just updated the command :)

Thank you

@dfawley
Copy link
Member

dfawley commented Jan 21, 2022

Was there something wrong with the previous command for you? This is how we run it and it works fine.

@eko
Copy link
Author

eko commented Jan 22, 2022

You're right again @dfawley, it seems to also work as it is so I close this PR :)

I've seen that Protobuf also supports a _opt suffix to specify options (see: protocolbuffers/protobuf#6999) so I'm using it in my projects but passing options using , separator to _out suffix is also working correctly.

Thank for your time.

@eko eko closed this Jan 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley requested changes

@menghanl menghanl menghanl approved these changes

Assignees

@eko eko

Labels
Status: Requires Reporter Clarification Type: Documentation Documentation or examples
Projects
None yet
Milestone
1.45 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@eko @dfawley @menghanl