Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --<lang>_opt flag for all built-in generators #6999

Merged
merged 1 commit into from
Dec 10, 2019

Conversation

Yannic
Copy link
Contributor

@Yannic Yannic commented Dec 9, 2019

Plugins (and some built-in generators) allow passing parameters
with --<lang>_opt one-by-one instead of passing them as
--<lang>_out=<params>:<out_base>. This PR changes protoc to
allow using --<lang>_opt for all (built-in) generators.

Plugins (and some built-in generators) have `--<lang>_opt` flag that
allows passing parameters one-by-one instead of passing them as
`--<lang>_out=<params>:<out_base>`. This PR changes protoc to
allow using `--<lang>_opt` for all (built-in) generators.
@Yannic
Copy link
Contributor Author

Yannic commented Dec 10, 2019

Thanks! The failures look unrelated to this change.

macOS Python Release:

+ sudo installer -pkg downloads/python-3.5.4-macosx10.9.pkg -target /
installer: Error - the package path specified was invalid: 'downloads/python-3.5.4-macosx10.9.pkg'.


[ID: 4240753] Build finished after 622 secs, exit value: 1

macOS Ruby 2.3

Ruby was built without documentation, to build it run: rvm docs generate-ri
Using /Users/kbuilder/.rvm/gems/ruby-2.3.8
/Users/kbuilder/.rvm/rubies/ruby-2.3.8/bin/ruby
ERROR:  Loading command: install (LoadError)
	cannot load such file -- openssl
ERROR:  While executing gem ... (NoMethodError)
    undefined method `invoke_with_build_args' for nil:NilClass


[ID: 2752210] Build finished after 705 secs, exit value: 1

macOS Ruby Release timed out, not sure why but I'm sure not because of this change.

@acozzette acozzette merged commit 4447fcc into protocolbuffers:master Dec 10, 2019
@acozzette
Copy link
Member

@Yannic Thanks for the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants