Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick observability changes from master to v1.50.x and update version to 1.50.1 #5722

Merged
merged 5 commits into from
Oct 14, 2022
Merged

Cherry-pick observability changes from master to v1.50.x and update version to 1.50.1 #5722

merged 5 commits into from
Oct 14, 2022

Conversation

zasweq
Copy link
Contributor

@zasweq zasweq commented Oct 14, 2022 •
edited
Loading

RELEASE NOTES:

  • gcp/observability: support new configuration defined in public preview user guide

@zasweq zasweq added this to the 1.51 Release milestone Oct 14, 2022
@zasweq zasweq added the Type: Meta Github repo, process, etc label Oct 14, 2022
@zasweq zasweq requested a review from arvindbr8 October 14, 2022 21:09
arvindbr8
arvindbr8 approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@arvindbr8 arvindbr8 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a failing test.but otherwise lgtm

arvindbr8
arvindbr8 requested changes Oct 14, 2022
View reviewed changes
Copy link
Member

@arvindbr8 arvindbr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a failing test in the PR here

@arvindbr8 arvindbr8 assigned zasweq and unassigned arvindbr8 Oct 14, 2022
arvindbr8
arvindbr8 approved these changes Oct 14, 2022
View reviewed changes
Copy link
Member

@arvindbr8 arvindbr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the failed tests are known and tracked here #5663

@zasweq zasweq changed the title Cherry-pick observability changes from master to v1.50.x and update version to 1.50.2 Cherry-pick observability changes from master to v1.50.x and update version to 1.50.1 Oct 14, 2022
@zasweq zasweq merged commit 4c776ec into grpc:v1.50.x Oct 14, 2022
1 check passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@arvindbr8 arvindbr8 arvindbr8 approved these changes

Assignees

@zasweq zasweq

Labels
Type: Meta Github repo, process, etc
Projects
None yet
Milestone
1.51 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@zasweq @arvindbr8 @dfawley