Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security/advancedtls: fix test that relies on min TLS version #6824

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

rolandshoemaker
Copy link
Contributor

@rolandshoemaker rolandshoemaker commented Nov 29, 2023

Go 1.22 changed the default TLS minimum version. Toolchains which do not respect go.mod 'go' version directives will break when executing the Test/GetCertificatesSNI/Select_serverCert3 test, since it relies on the private tls.ClientHelloInfo.config fields minimum version matching the configured tls.ClientHelloInfo.SupportedVersions field. This change just bumps the version in tls.ClientHelloInfo.SupportedVersions to tls.VersionTLS12.

With Go 1.22, gRPC users will still be able to use TLS versions VersionTLS10, VersionTLS11 by utilizing MinVersion and MaxVersion parameters of ClientOptions struct.

b/315783527

RELEASE NOTES: N/A

Go 1.22 changed the default TLS minimum version. Toolchains which do not
respect go.mod 'go' version directives will break when executing the
Test/GetCertificatesSNI/Select_serverCert3 test, since it relies on the
private tls.ClientHelloInfo.config fields minimum version matching the
configured tls.ClientHelloInfo.SupportedVersions field. This change just
bumps the version in tls.ClientHelloInfo.SupportedVersions to
tls.VersionTLS12.

This fixes an internal google test.
Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Merging #6824 (d29c20d) into master (737f87b) will decrease coverage by 0.07%.
Report is 9 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6824      +/-   ##
==========================================
- Coverage   83.58%   83.51%   -0.07%     
==========================================
  Files         285      285              
  Lines       30879    30879              
==========================================
- Hits        25811    25790      -21     
- Misses       4005     4023      +18     
- Partials     1063     1066       +3     

see 16 files with indirect coverage changes

@erm-g erm-g added this to the 1.61 Release milestone Dec 12, 2023
@erm-g erm-g self-requested a review December 12, 2023 20:45
@erm-g erm-g merged commit 686fdd8 into grpc:master Dec 12, 2023
14 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants