.*: fix revive lint issues unused-parameter
#7580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-error-flow, var-declaration
Optimising the code by fixing var-declaration, indent-error-flow, increment-decrement, superfluous-else
…low, increment-decrement, superfluous-else"
Revert "Optimising the code by fixing var-declaration, indent-error-flow, increment-decrement, superfluous-else"
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7580 +/- ##
==========================================
+ Coverage 81.73% 81.76% +0.02%
==========================================
Files 361 361
Lines 27809 27809
==========================================
+ Hits 22730 22737 +7
+ Misses 3869 3867 -2
+ Partials 1210 1205 -5
|
|
There are still some |
|
@purnesh42H Fixed all the unused-parameter linter issues. |
purnesh42H
changed the title
unused-parameter
|
@arvindbr8 for another review |
arvindbr8
approved these changes
Sep 3, 2024
Closed
13 tasks
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: #7444
RELEASE NOTES: None