mem: use slice capacity instead of length, to determine whether to pool buffers or directly allocate them #7702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PapaCharlie
force-pushed
the
pc/poolshortbuffers
branch
from
1ab352d to
5d2cb0c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7702 +/- ##
==========================================
- Coverage 81.80% 81.32% -0.49%
==========================================
Files 361 368 +7
Lines 27827 36772 +8945
==========================================
+ Hits 22765 29906 +7141
- Misses 3861 5636 +1775
- Partials 1201 1230 +29
|
As the issue states, `mem.NewBuffer` would not pool buffers with a length below the pooling threshold but whose capacity is actually larger than the pooling threshold. This can lead to buffers being leaked.
PapaCharlie
force-pushed
the
pc/poolshortbuffers
branch
from
5d2cb0c to
aed354b
Compare
easwars
changed the title
easwars
approved these changes
Oct 8, 2024
purnesh42H
added a commit
to purnesh42H/grpc-go
that referenced
this pull request
Oct 29, 2024
…ol buffers or directly allocate them (grpc#7702) * Address grpc#7631 by correctly pooling large-capacity buffers As the issue states, `mem.NewBuffer` would not pool buffers with a length below the pooling threshold but whose capacity is actually larger than the pooling threshold. This can lead to buffers being leaked. --------- Co-authored-by: Purnesh Dixit <purneshdixit@google.com> Co-authored-by: Easwar Swaminathan <easwars@google.com>
purnesh42H
added a commit
to purnesh42H/grpc-go
that referenced
this pull request
Oct 29, 2024
…ol buffers or directly allocate them (grpc#7702) * Address grpc#7631 by correctly pooling large-capacity buffers As the issue states, `mem.NewBuffer` would not pool buffers with a length below the pooling threshold but whose capacity is actually larger than the pooling threshold. This can lead to buffers being leaked. --------- Co-authored-by: Purnesh Dixit <purneshdixit@google.com> Co-authored-by: Easwar Swaminathan <easwars@google.com>
purnesh42H
added a commit
to purnesh42H/grpc-go
that referenced
this pull request
Oct 29, 2024
…ol buffers or directly allocate them (grpc#7702) * Address grpc#7631 by correctly pooling large-capacity buffers As the issue states, `mem.NewBuffer` would not pool buffers with a length below the pooling threshold but whose capacity is actually larger than the pooling threshold. This can lead to buffers being leaked. --------- Co-authored-by: Purnesh Dixit <purneshdixit@google.com> Co-authored-by: Easwar Swaminathan <easwars@google.com>
misvivek
pushed a commit
to misvivek/grpc-go
that referenced
this pull request
Nov 7, 2024
…ol buffers or directly allocate them (grpc#7702) * Address grpc#7631 by correctly pooling large-capacity buffers As the issue states, `mem.NewBuffer` would not pool buffers with a length below the pooling threshold but whose capacity is actually larger than the pooling threshold. This can lead to buffers being leaked. --------- Co-authored-by: Purnesh Dixit <purneshdixit@google.com> Co-authored-by: Easwar Swaminathan <easwars@google.com>
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7631
As the issue states,
mem.NewBufferwould not pool buffers with a length below the pooling threshold but whose capacity is actually larger than the pooling threshold. This can lead to buffers being leaked.RELEASE NOTES: