Cherry-pick #7702 into v1.68.x #7791

purnesh42H · 2024-10-29T15:48:50Z

Original PR: #7702

RELEASE NOTES:

mem: use slice capacity instead of length, to determine whether to pool buffers or directly allocate them

…rpc#7734)

…c#7717)

…c#7721)

* Update gRPC-Go's dependency versions on master * update protos * disabled redefines-builtin-id lint rule

…ForClient (grpc#7754)

…on-regeneratable proto code into /testdata (grpc#7724)

…purposes (grpc#7771)

…ol buffers or directly allocate them (grpc#7702) * Address grpc#7631 by correctly pooling large-capacity buffers As the issue states, `mem.NewBuffer` would not pool buffers with a length below the pooling threshold but whose capacity is actually larger than the pooling threshold. This can lead to buffers being leaked. --------- Co-authored-by: Purnesh Dixit <purneshdixit@google.com> Co-authored-by: Easwar Swaminathan <easwars@google.com>

…connection (grpc#7772)

…1.23 (grpc#7751)

…pc#7775) * Replace the gRFC pull request with the permanent link. * add ALTSPerRPCCreds in DefaultCredentialsOptions to support channel aware RPC creds * go vet * address comment

…ementation (grpc#7708)

…e2e tests (grpc#7759)

refactor GRPCTraceBinPropagator to be exported externally Use context instead of metadata in CustomCarrier

…comments

…ol buffers or directly allocate them (grpc#7702) * Address grpc#7631 by correctly pooling large-capacity buffers As the issue states, `mem.NewBuffer` would not pool buffers with a length below the pooling threshold but whose capacity is actually larger than the pooling threshold. This can lead to buffers being leaked. --------- Co-authored-by: Purnesh Dixit <purneshdixit@google.com> Co-authored-by: Easwar Swaminathan <easwars@google.com>

codecov · 2024-10-29T15:53:49Z

Codecov Report

Attention: Patch coverage is 68.57923% with 345 lines in your changes missing coverage. Please review.

Project coverage is 81.92%. Comparing base (54841ef) to head (c039978).

Files with missing lines	Patch %	Lines
xds/internal/xdsclient/transport/ads/ads_stream.go	72.76%	104 Missing and 21 partials ⚠️
xds/internal/xdsclient/transport/lrs/lrs_stream.go	38.74%	111 Missing and 6 partials ⚠️
xds/internal/xdsclient/channel.go	78.76%	24 Missing and 7 partials ⚠️
.../grpc_testing_not_regenerated/simple_message_v1.go	29.16%	17 Missing ⚠️
...s/opentelemetry/internal/tracing/custom_carrier.go	82.75%	7 Missing and 3 partials ⚠️
...xdsclient/transport/grpctransport/grpctransport.go	83.33%	7 Missing and 2 partials ⚠️
xds/internal/resolver/xds_resolver.go	33.33%	6 Missing ⚠️
credentials/google/google.go	70.58%	4 Missing and 1 partial ⚠️
...pentelemetry/internal/grpc_trace_bin_propagator.go	90.38%	4 Missing and 1 partial ⚠️
balancer/rls/config.go	0.00%	2 Missing and 1 partial ⚠️
... and 6 more

Additional details and impacted files

@@             Coverage Diff             @@
##           v1.68.x    #7791      +/-   ##
===========================================
- Coverage    82.24%   81.92%   -0.32%     
===========================================
  Files          362      376      +14     
  Lines        28116    38259   +10143     
===========================================
+ Hits         23123    31345    +8222     
- Misses        3815     5653    +1838     
- Partials      1178     1261      +83

Files with missing lines	Coverage Δ
clientconn.go	`92.14% <100.00%> (-0.88%)`	⬇️
credentials/tls.go	`86.57% <100.00%> (+0.21%)`	⬆️
internal/status/status.go	`90.52% <100.00%> (+0.65%)`	⬆️
internal/testutils/wrappers.go	`87.50% <100.00%> (-2.98%)`	⬇️
internal/transport/flowcontrol.go	`96.49% <100.00%> (-0.39%)`	⬇️
mem/buffers.go	`88.18% <100.00%> (+4.34%)`	⬆️
resolver/resolver.go	`100.00% <100.00%> (ø)`
testdata/grpc_testing_not_regenerated/testv3.go	`6.86% <ø> (ø)`
xds/googledirectpath/googlec2p.go	`93.10% <100.00%> (+0.65%)`	⬆️
xds/internal/xdsclient/authority.go	`89.75% <100.00%> (+0.51%)`	⬆️
... and 21 more

... and 300 files with indirect coverage changes

purnesh42H and others added 30 commits October 16, 2024 11:14

Change version to 1.69.0-dev (grpc#7746)

4544b8a

vet: Use go1.22 instead of go1.21 for tidy and staticcheck(grpc#7747)

569c8eb

clientconn: remove redundant check (grpc#7700)

6cd00c9

transport: refactor trInFlow.onData to eliminate redundant logic (g…

ec10e73

…rpc#7734)

xdsclient: new Transport interface and LRS stream implementation (grp…

d2ded4b

…c#7717)

xdsclient: new Transport interface and ADS stream implementation (grp…

830135e

…c#7721)

resolver: update ReportError() docstring (grpc#7732)

56df169

deps: update dependencies for all modules (grpc#7755)

98959d9

* Update gRPC-Go's dependency versions on master * update protos * disabled redefines-builtin-id lint rule

resolver/google-c2p: introduce SetUniverseDomain API (grpc#7719)

14e2a20

vet: Don't use GOROOT to set PATH if GOROOT is unset (grpc#7761)

c538c31

credentials: Apply defaults to TLS configs provided through GetConfig…

80937a9

…ForClient (grpc#7754)

status: Fix status incompatibility introduced by grpc#6919 and move n…

4bb0170

…on-regeneratable proto code into /testdata (grpc#7724)

xdsclient: implementation of the xdsChannel (grpc#7757)

8212cf0

xds/resolver: add a way to specify the xDS client to use for testing …

c4c8b11

…purposes (grpc#7771)

clusterresolver: fix a comment in a test (grpc#7776)

e0a730c

testutils: change ListenerWrapper to push the most recently accepted …

a82315c

…connection (grpc#7772)

vet: add dependency checks (grpc#7766)

94e1b29

xdsclient: make sending requests more deterministic (grpc#7774)

67b9ebf

github: add Go 1.23 testing and make staticcheck work locally with go…

a0cbb52

…1.23 (grpc#7751)

credentials: Support ALTSPerRPCCreds in DefaultCredentialsOptions (gr…

cb32937

…pc#7775) * Replace the gRFC pull request with the permanent link. * add ALTSPerRPCCreds in DefaultCredentialsOptions to support channel aware RPC creds * go vet * address comment

cleanup: switching to stubserver in tests instead of testservice impl…

ada6787

…ementation (grpc#7708)

stats/opentelemetry: Remove OpenTelemetry module and add RLS Metrics …

4084b14

…e2e tests (grpc#7759)

balancer/endpointsharding: Ignore empty endpoints (grpc#7674)

e7435d6

multiple: add verbosity checks to logs that use pretty.JSON (grpc#7785)

192ee33

stats: opentelemetry GrpcTraceBinPropagator

a197f9b

refactor GRPCTraceBinPropagator to be exported externally Use context instead of metadata in CustomCarrier

Address style, clarification review comments

3df92be

Make *CustomCarrier implement carrier interface

d9f548b

Address 2nd round of style, docstring comments

857b023

use cmp.equal with cmpopts.SortSlices for equating keys slices

afe897e

purnesh42H and others added 9 commits October 29, 2024 10:38

separate fast path and slow path tests

1b8e64a

Addressing documentation comments

24a9f2b

rewrite FromBinary as C core and add unit tests

ccb0b30

handle grpc-trace-bin keys for regular get and set

80530d6

Address nits

89f21ed

don't allow any other binary header except grpc-trace-bin

4a81f71

Suffix -bin instead of bin

eec4212

address testing comments of merging in t-test and updating top level …

2dfe0c3

…comments

purnesh42H requested review from easwars and dfawley October 29, 2024 15:48

purnesh42H closed this Oct 29, 2024

purnesh42H deleted the cherry-pick-7702 branch October 29, 2024 17:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Cherry-pick #7702 into v1.68.x #7791

Cherry-pick #7702 into v1.68.x #7791

purnesh42H commented Oct 29, 2024

codecov bot commented Oct 29, 2024 •

edited

Loading

Cherry-pick #7702 into v1.68.x #7791

Cherry-pick #7702 into v1.68.x #7791

Conversation

purnesh42H commented Oct 29, 2024

codecov bot commented Oct 29, 2024 • edited Loading

Codecov Report

codecov bot commented Oct 29, 2024 •

edited

Loading