Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a pair of issues that prevent complete cacheability of certain tasks in the project's build:
build.gradle
file in such a way that the dependency is registered with the full absolute path of the project on the local node. This makes it impossible to cache those tasks between two nodes with a different directory layout. Fixed by specifying that the file path should be relative to the project dir.NettyResourceTransformer
object innetty/shaded/build.gradle
is not explicitly marked as cacheable. This, I admit, I took more of a guess that it was an oversight, but if there's a reason, I can drop that from the PR.UPDATE:
These are the build scans that demonstrate the change:
You can clearly see here that tasks move "not cacheable" to "cacheable" as a result of this change.