Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Improvements #9855

Merged
merged 3 commits into from
Feb 6, 2023
Merged

Build Improvements #9855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
93be0a3
Made dependency on build.gradle in protobuf tasks relative so as to m…
asafflesch Jan 23, 2023
3025d85
Made transformer cacheable
asafflesch Jan 23, 2023
7649cfb
Add property name to path to root build.gradle
asafflesch Jan 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,9 @@ subprojects {
all().each { task ->
// Recompile protos when build.gradle has been changed, because
// it's possible the version of protoc has been changed.
task.inputs.file "${rootProject.projectDir}/build.gradle"
task.inputs.file("${rootProject.projectDir}/build.gradle")
.withPathSensitivity(PathSensitivity.RELATIVE)
.withPropertyName('root build.gradle')
if (isAndroid) {
task.builtins {
java { option 'lite' }
Expand Down
2 changes: 2 additions & 0 deletions netty/shaded/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import com.github.jengelman.gradle.plugins.shadow.transformers.Transformer
import com.github.jengelman.gradle.plugins.shadow.transformers.CacheableTransformer
import com.github.jengelman.gradle.plugins.shadow.transformers.TransformerContext
import org.gradle.api.file.FileTreeElement
import shadow.org.apache.tools.zip.ZipOutputStream
Expand Down Expand Up @@ -140,6 +141,7 @@ tasks.named("test").configure {
* A Transformer which updates the Netty JAR META-INF/ resources to accurately
* reference shaded class names.
*/
@CacheableTransformer
class NettyResourceTransformer implements Transformer {

// A map of resource file paths to be modified
Expand Down